[R] Add test coverage for joins with duplicate columns and type casting

Author: HyukjinKwon

r/tests/testthat/test-dplyr-join.R

@@ -188,8 +188,84 @@ test_that("Error handling for unsupported expressions in join_by", {
   )
 })
 
-# TODO: test duplicate col names
-# TODO: casting: int and float columns?
+test_that("joins with duplicate column names", {
+  # When column names are duplicated (not in by), suffixes are added
+  left_dup <- tibble::tibble(
+    x = 1:5,
+    y = 1:5,
+    z = letters[1:5]
+  )
+  right_dup <- tibble::tibble(
+    x = 1:5,
+    y = 6:10,
+    z = LETTERS[1:5]
+  )
+
+  compare_dplyr_binding(
+    .input |>
+      left_join(right_dup, by = "x") |>
+      collect(),
+    left_dup
+  )
+
+  compare_dplyr_binding(
+    .input |>
+      inner_join(right_dup, by = "x") |>
+      collect(),
+    left_dup
+  )
+
+  # Test with custom suffixes
+  compare_dplyr_binding(
+    .input |>
+      left_join(right_dup, by = "x", suffix = c("_left", "_right")) |>
+      collect(),
+    left_dup
+  )
+})
+
+test_that("joins with type casting between int and float", {
+  # Joins should work when one side has int and the other has float
+  left_int <- tibble::tibble(
+    x = 1:5,
+    value = letters[1:5]
+  )
+  right_float <- tibble::tibble(
+    x = as.numeric(1:5),
+    info = LETTERS[1:5]
+  )
+
+  compare_dplyr_binding(
+    .input |>
+      left_join(right_float, by = "x") |>
+      collect(),
+    left_int
+  )
+
+  compare_dplyr_binding(
+    .input |>
+      inner_join(right_float, by = "x") |>
+      collect(),
+    left_int
+  )
+
+  # Also test the reverse (float on left, int on right)
+  left_float <- tibble::tibble(
+    x = as.numeric(1:5),
+    value = letters[1:5]
+  )
+  right_int <- tibble::tibble(
+    x = 1:5,
+    info = LETTERS[1:5]
+  )
+
+  compare_dplyr_binding(
+    .input |>
+      left_join(right_int, by = "x") |>
+      collect(),
+    left_float
+  )
+})
 
 test_that("right_join", {
   compare_dplyr_binding(