Skip to content

Commit 00850ea

Browse files
committed
use appropriate zoneId during clone bkp offering
1 parent 1c18d31 commit 00850ea

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -346,12 +346,12 @@ public BackupOffering cloneBackupOffering(final CloneBackupOfferingCmd cmd) {
346346
final Long zoneId = cmd.getZoneId() != null ? cmd.getZoneId() : sourceOffering.getZoneId();
347347

348348
if (!Objects.equals(sourceOffering.getExternalId(), externalId)) {
349-
final BackupProvider provider = getBackupProvider(sourceOffering.getZoneId());
350-
if (!provider.isValidProviderOffering(sourceOffering.getZoneId(), externalId)) {
351-
throw new CloudRuntimeException("Backup offering '" + externalId + "' does not exist on provider " + provider.getName() + " on zone " + sourceOffering.getZoneId());
349+
final BackupProvider provider = getBackupProvider(zoneId);
350+
if (!provider.isValidProviderOffering(zoneId, externalId)) {
351+
throw new CloudRuntimeException("Backup offering '" + externalId + "' does not exist on provider " + provider.getName() + " on zone " + zoneId);
352352
}
353353

354-
final BackupOffering existingOffering = backupOfferingDao.findByExternalId(externalId, sourceOffering.getZoneId());
354+
final BackupOffering existingOffering = backupOfferingDao.findByExternalId(externalId, zoneId);
355355
if (existingOffering != null) {
356356
throw new CloudRuntimeException("A backup offering with external ID '" + externalId + "' already exists in this zone");
357357
}

0 commit comments

Comments
 (0)