Skip to content

Commit 38181b2

Browse files
authored
Optional chaining used to enhance readability (#5961)
* Optional chaining used to enhance readability * Added Suggested change Co-authored-by: YashikaSarkar <65132044+YashikaSarkar@users.noreply.github.com>
1 parent 41d25d5 commit 38181b2

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

ui/src/components/header/ProjectMenu.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export default {
7979
const getNextPage = () => {
8080
this.loading = true
8181
api('listProjects', { listAll: true, details: 'min', page: page, pageSize: 500, showIcon: true }).then(json => {
82-
if (json && json.listprojectsresponse && json.listprojectsresponse.project) {
82+
if (json?.listprojectsresponse?.listprojectsresponse.project) {
8383
projects.push(...json.listprojectsresponse.project)
8484
}
8585
if (projects.length < json.listprojectsresponse.count) {

ui/src/components/view/BulkActionProgress.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export default {
155155
this.tableChanged = true
156156
},
157157
filterItems () {
158-
if (this.appliedFilterStatus && this.appliedFilterStatus.length > 0) {
158+
if (this.appliedFilterStatus?.length > 0) {
159159
this.filteredItems = this.selectedItems.filter(item => {
160160
if (this.appliedFilterStatus.includes(item.status)) {
161161
return item

ui/src/components/view/DedicateData.vue

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,7 @@ export default {
121121
api('listDedicatedZones', {
122122
zoneid: this.resource.id
123123
}).then(response => {
124-
if (response.listdedicatedzonesresponse.dedicatedzone &&
125-
response.listdedicatedzonesresponse.dedicatedzone.length > 0) {
124+
if (response?.listdedicatedzonesresponse?.dedicatedzone?.length > 0) {
126125
this.dedicatedDomainId = response.listdedicatedzonesresponse.dedicatedzone[0].domainid
127126
this.dedicatedAccountId = response.listdedicatedzonesresponse.dedicatedzone[0].accountid
128127
}
@@ -134,8 +133,7 @@ export default {
134133
api('listDedicatedPods', {
135134
podid: this.resource.id
136135
}).then(response => {
137-
if (response.listdedicatedpodsresponse.dedicatedpod &&
138-
response.listdedicatedpodsresponse.dedicatedpod.length > 0) {
136+
if (response?.listdedicatedpodsresponse?.dedicatedpod?.length > 0) {
139137
this.dedicatedDomainId = response.listdedicatedpodsresponse.dedicatedpod[0].domainid
140138
this.dedicatedAccountId = response.listdedicatedpodsresponse.dedicatedpod[0].accountid
141139
}
@@ -147,8 +145,7 @@ export default {
147145
api('listDedicatedClusters', {
148146
clusterid: this.resource.id
149147
}).then(response => {
150-
if (response.listdedicatedclustersresponse.dedicatedcluster &&
151-
response.listdedicatedclustersresponse.dedicatedcluster.length > 0) {
148+
if (response?.listdedicatedclustersresponse?.dedicatedcluster?.length > 0) {
152149
this.dedicatedDomainId = response.listdedicatedclustersresponse.dedicatedcluster[0].domainid
153150
this.dedicatedAccountId = response.listdedicatedclustersresponse.dedicatedcluster[0].accountid
154151
}
@@ -160,8 +157,7 @@ export default {
160157
api('listDedicatedHosts', {
161158
hostid: this.resource.id
162159
}).then(response => {
163-
if (response.listdedicatedhostsresponse.dedicatedhost &&
164-
response.listdedicatedhostsresponse.dedicatedhost.length > 0) {
160+
if (response?.listdedicatedhostsresponse?.dedicatedhost?.length > 0) {
165161
this.dedicatedDomainId = response.listdedicatedhostsresponse.dedicatedhost[0].domainid
166162
this.dedicatedAccountId = response.listdedicatedhostsresponse.dedicatedhost[0].accountid
167163
}

0 commit comments

Comments
 (0)