Skip to content

Commit 579c721

Browse files
committed
cloudutils: Fix regression from PR#2033
This fixes regression from PR #2033 which breaks cloudstack deployment for centos6/7. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
1 parent 248cecd commit 579c721

File tree

1 file changed

+24
-16
lines changed

1 file changed

+24
-16
lines changed

python/lib/cloudutils/serviceConfigServer.py

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,12 @@ def checkHostName():
8989
if os.path.exists("/etc/cloudstack/management/server.xml"):
9090
bash("rm -f /etc/cloudstack/management/server.xml")
9191
bash("ln -s /etc/cloudstack/management/server7-ssl.xml /etc/cloudstack/management/server.xml")
92-
bash("rm -f /usr/share/cloudstack-management/bin")
93-
bash("rm -f /usr/share/cloudstack-management/lib")
94-
bash("ln -s /usr/share/tomcat7/bin /usr/share/cloudstack-management/bin")
95-
bash("ln -s /usr/share/tomcat7/lib /usr/share/cloudstack-management/lib")
92+
if os.path.exists("/usr/share/tomcat7/bin"):
93+
bash("rm -f /usr/share/cloudstack-management/bin")
94+
bash("ln -s /usr/share/tomcat7/bin /usr/share/cloudstack-management/bin")
95+
if os.path.exists("/usr/share/tomcat7/lib"):
96+
bash("rm -f /usr/share/cloudstack-management/lib")
97+
bash("ln -s /usr/share/tomcat7/lib /usr/share/cloudstack-management/lib")
9698
else:
9799
if not os.path.exists("/etc/cloudstack/management/server-ssl.xml") or not os.path.exists("/etc/cloudstack/management/tomcat6-ssl.conf"):
98100
raise CloudRuntimeException("Cannot find /etc/cloudstack/management/server-ssl.xml or /etc/cloudstack/management/tomcat6-ssl.conf, https enable failed")
@@ -102,10 +104,12 @@ def checkHostName():
102104
bash("rm -f /etc/cloudstack/management/tomcat6.conf")
103105
bash("ln -s /etc/cloudstack/management/server-ssl.xml /etc/cloudstack/management/server.xml")
104106
bash("ln -s /etc/cloudstack/management/tomcat6-ssl.conf /etc/cloudstack/management/tomcat6.conf")
105-
bash("rm -f /usr/share/cloudstack-management/bin")
106-
bash("rm -f /usr/share/cloudstack-management/lib")
107-
bash("ln -s /usr/share/tomcat6/bin /usr/share/cloudstack-management/bin")
108-
bash("ln -s /usr/share/tomcat6/lib /usr/share/cloudstack-management/lib")
107+
if os.path.exists("/usr/share/tomcat6/bin"):
108+
bash("rm -f /usr/share/cloudstack-management/bin")
109+
bash("ln -s /usr/share/tomcat6/bin /usr/share/cloudstack-management/bin")
110+
if os.path.exists("/usr/share/tomcat6/lib"):
111+
bash("rm -f /usr/share/cloudstack-management/lib")
112+
bash("ln -s /usr/share/tomcat6/lib /usr/share/cloudstack-management/lib")
109113
if not bash("iptables-save |grep PREROUTING | grep 6443").isSuccess():
110114
bash("iptables -A PREROUTING -t nat -p tcp --dport 443 -j REDIRECT --to-port 6443")
111115
else:
@@ -115,10 +119,12 @@ def checkHostName():
115119
if os.path.exists("/etc/cloudstack/management/server.xml"):
116120
bash("rm -f /etc/cloudstack/management/server.xml")
117121
bash("ln -s /etc/cloudstack/management/server7-nonssl.xml /etc/cloudstack/management/server.xml")
118-
bash("rm -f /usr/share/cloudstack-management/bin")
119-
bash("rm -f /usr/share/cloudstack-management/lib")
120-
bash("ln -s /usr/share/tomcat7/bin /usr/share/cloudstack-management/bin")
121-
bash("ln -s /usr/share/tomcat7/lib /usr/share/cloudstack-management/lib")
122+
if os.path.exists("/usr/share/tomcat7/bin"):
123+
bash("rm -f /usr/share/cloudstack-management/bin")
124+
bash("ln -s /usr/share/tomcat7/bin /usr/share/cloudstack-management/bin")
125+
if os.path.exists("/usr/share/tomcat7/lib"):
126+
bash("rm -f /usr/share/cloudstack-management/lib")
127+
bash("ln -s /usr/share/tomcat7/lib /usr/share/cloudstack-management/lib")
122128
else:
123129
if not os.path.exists("/etc/cloudstack/management/server-nonssl.xml") or not os.path.exists("/etc/cloudstack/management/tomcat6-nonssl.conf"):
124130
raise CloudRuntimeException("Cannot find /etc/cloudstack/management/server-nonssl.xml or /etc/cloudstack/management/tomcat6-nonssl.conf, https enable failed")
@@ -128,10 +134,12 @@ def checkHostName():
128134
bash("rm -f /etc/cloudstack/management/tomcat6.conf")
129135
bash("ln -s /etc/cloudstack/management/server-nonssl.xml /etc/cloudstack/management/server.xml")
130136
bash("ln -s /etc/cloudstack/management/tomcat6-nonssl.conf /etc/cloudstack/management/tomcat6.conf")
131-
bash("rm -f /usr/share/cloudstack-management/bin")
132-
bash("rm -f /usr/share/cloudstack-management/lib")
133-
bash("ln -s /usr/share/tomcat6/bin /usr/share/cloudstack-management/bin")
134-
bash("ln -s /usr/share/tomcat6/lib /usr/share/cloudstack-management/lib")
137+
if os.path.exists("/usr/share/tomcat6/bin"):
138+
bash("rm -f /usr/share/cloudstack-management/bin")
139+
bash("ln -s /usr/share/tomcat6/bin /usr/share/cloudstack-management/bin")
140+
if os.path.exists("/usr/share/tomcat6/lib"):
141+
bash("rm -f /usr/share/cloudstack-management/lib")
142+
bash("ln -s /usr/share/tomcat6/lib /usr/share/cloudstack-management/lib")
135143
bash("touch /var/run/cloudstack-management.pid")
136144
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
137145
#distro like sl 6.1 needs this folder, or tomcat6 failed to start

0 commit comments

Comments
 (0)