storage: Linstor volume plugin (#4994)

This adds a volume(primary) storage plugin for the Linstor SDS.
Currently it can create/delete/migrate volumes, snapshots should be possible,
but currently don't work for RAW volume types in cloudstack.

* plugin-storage-volume-linstor: notify libvirt guests about the resize

Author: rp-

api/src/main/java/com/cloud/storage/Storage.java

@@ -147,6 +147,7 @@ public static enum StoragePoolType {
         Gluster(true, false),
         PowerFlex(true, true), // Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
         ManagedNFS(true, false),
+        Linstor(true, true),
         DatastoreCluster(true, true); // for VMware, to abstract pool of clusters
 
         private final boolean shared;

api/src/test/java/com/cloud/storage/StorageTest.java

@@ -48,6 +48,7 @@ public void isSharedStoragePool() {
         Assert.assertTrue(StoragePoolType.Gluster.isShared());
         Assert.assertTrue(StoragePoolType.ManagedNFS.isShared());
         Assert.assertTrue(StoragePoolType.DatastoreCluster.isShared());
+        Assert.assertTrue(StoragePoolType.Linstor.isShared());
     }
 
     @Test
@@ -71,5 +72,6 @@ public void supportsOverprovisioningStoragePool() {
         Assert.assertFalse(StoragePoolType.Gluster.supportsOverProvisioning());
         Assert.assertFalse(StoragePoolType.ManagedNFS.supportsOverProvisioning());
         Assert.assertTrue(StoragePoolType.DatastoreCluster.supportsOverProvisioning());
+        Assert.assertTrue(StoragePoolType.Linstor.supportsOverProvisioning());
     }
 }

client/pom.xml

@@ -92,6 +92,11 @@
             <artifactId>cloud-plugin-storage-volume-scaleio</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.cloudstack</groupId>
+            <artifactId>cloud-plugin-storage-volume-linstor</artifactId>
+            <version>${project.version}</version>
+        </dependency>
         <dependency>
             <groupId>org.apache.cloudstack</groupId>
             <artifactId>cloud-server</artifactId>

engine/storage/integration-test/pom.xml

@@ -99,6 +99,12 @@
             <version>${project.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.cloudstack</groupId>
+            <artifactId>cloud-plugin-storage-volume-linstor</artifactId>
+            <version>${project.version}</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.apache.cloudstack</groupId>
             <artifactId>cloud-secondary-storage</artifactId>

plugins/hypervisors/kvm/pom.xml

@@ -62,6 +62,11 @@
             <artifactId>rados</artifactId>
             <version>${cs.rados-java.version}</version>
         </dependency>
+        <dependency>
+            <groupId>com.linbit.linstor.api</groupId>
+            <artifactId>java-linstor</artifactId>
+            <version>${cs.java-linstor.version}</version>
+        </dependency>
         <dependency>
             <groupId>net.java.dev.jna</groupId>
             <artifactId>jna</artifactId>

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

@@ -279,6 +279,8 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv
      */
     private static final String AARCH64 = "aarch64";
 
+    public static final String RESIZE_NOTIFY_ONLY = "NOTIFYONLY";
+
     private String _modifyVlanPath;
     private String _versionstringpath;
     private String _patchScriptPath;
@@ -1910,6 +1912,8 @@ public String getResizeScriptType(final KVMStoragePool pool, final KVMPhysicalDi
                 || poolType == StoragePoolType.Gluster)
                 && volFormat == PhysicalDiskFormat.QCOW2 ) {
             return "QCOW2";
+        } else if (poolType == StoragePoolType.Linstor) {
+            return RESIZE_NOTIFY_ONLY;
         }
         throw new CloudRuntimeException("Cannot determine resize type from pool type " + pool.getType());
     }

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java

@@ -57,7 +57,7 @@ public Answer execute(final ResizeVolumeCommand command, final LibvirtComputingR
         final String vmInstanceName = command.getInstanceName();
         final boolean shrinkOk = command.getShrinkOk();
         final StorageFilerTO spool = command.getPool();
-        final String notifyOnlyType = "NOTIFYONLY";
+        final String notifyOnlyType = LibvirtComputingResource.RESIZE_NOTIFY_ONLY;
 
         if ( currentSize == newSize) {
             // nothing to do
@@ -73,19 +73,20 @@ public Answer execute(final ResizeVolumeCommand command, final LibvirtComputingR
             final String path = vol.getPath();
             String type = notifyOnlyType;
 
-            if (pool.getType() != StoragePoolType.RBD) {
+            if (pool.getType() != StoragePoolType.RBD && pool.getType() != StoragePoolType.Linstor) {
                 type = libvirtComputingResource.getResizeScriptType(pool, vol);
                 if (type.equals("QCOW2") && shrinkOk) {
                     return new ResizeVolumeAnswer(command, false, "Unable to shrink volumes of type " + type);
                 }
             } else {
-                s_logger.debug("Volume " + path + " is on a RBD storage pool. No need to query for additional information.");
+                s_logger.debug("Volume " + path + " is on a RBD/Linstor storage pool. No need to query for additional information.");
             }
 
             s_logger.debug("Resizing volume: " + path + ", from: " + toHumanReadableSize(currentSize) + ", to: " + toHumanReadableSize(newSize) + ", type: " + type + ", name: " + vmInstanceName + ", shrinkOk: " + shrinkOk);
 
             /* libvirt doesn't support resizing (C)LVM devices, and corrupts QCOW2 in some scenarios, so we have to do these via Bash script */
-            if (pool.getType() != StoragePoolType.CLVM && vol.getFormat() != PhysicalDiskFormat.QCOW2) {
+            if (pool.getType() != StoragePoolType.CLVM && pool.getType() != StoragePoolType.Linstor &&
+                    vol.getFormat() != PhysicalDiskFormat.QCOW2) {
                 s_logger.debug("Volume " + path +  " can be resized by libvirt. Asking libvirt to resize the volume.");
                 try {
                     final LibvirtUtilitiesHelper libvirtUtilitiesHelper = libvirtComputingResource.getLibvirtUtilitiesHelper();

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java

@@ -378,7 +378,7 @@ public KVMPhysicalDisk createDiskFromTemplate(KVMPhysicalDisk template, String n
             return adaptor.createDiskFromTemplate(template, name,
                     PhysicalDiskFormat.DIR, provisioningType,
                     size, destPool, timeout);
-        } else if (destPool.getType() == StoragePoolType.PowerFlex) {
+        } else if (destPool.getType() == StoragePoolType.PowerFlex || destPool.getType() == StoragePoolType.Linstor) {
             return adaptor.createDiskFromTemplate(template, name,
                     PhysicalDiskFormat.RAW, provisioningType,
                     size, destPool, timeout);

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

@@ -282,7 +282,9 @@ public Answer copyTemplateToPrimaryStorage(final CopyCommand cmd) {
                 final TemplateObjectTO newTemplate = new TemplateObjectTO();
                 newTemplate.setPath(primaryVol.getName());
                 newTemplate.setSize(primaryVol.getSize());
-                if (primaryPool.getType() == StoragePoolType.RBD || primaryPool.getType() == StoragePoolType.PowerFlex) {
+                if (primaryPool.getType() == StoragePoolType.RBD ||
+                    primaryPool.getType() == StoragePoolType.PowerFlex ||
+                    primaryPool.getType() == StoragePoolType.Linstor) {
                     newTemplate.setFormat(ImageFormat.RAW);
                 } else {
                     newTemplate.setFormat(ImageFormat.QCOW2);