Update systemvm/debian/root/health_checks/haproxy_check.py

copilot suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: bradh352

systemvm/debian/root/health_checks/haproxy_check.py

@@ -29,14 +29,44 @@ def checkMaxconn(haproxyData, haCfgSections):
     return True
 
 def checkIdletimeout(haproxyData, haCfgSections):
-    if "idletimeout" in haproxyData:
-        if "timeout client" not in haCfgSections["defaults"] or "timeout server" not in haCfgSections["defaults"]:
-            print("defaults timeout client or timeout server missing")
+    if "idletimeout" not in haproxyData:
+        return True
 
-        if haproxyData["idletimeout"] != haCfgSections["defaults"]["timeout client"][0].strip() or haproxyData["idletimeout"] != haCfgSections["defaults"]["timeout server"][0].strip():
-            print("defaults timeout client or timeout server mismatch occurred")
+    # Normalize idletimeout value to string for comparison
+    idle_value = str(haproxyData["idletimeout"]).strip()
+
+    # Safely get the defaults section and its timeout directives
+    defaults_section = haCfgSections.get("defaults", {})
+    timeout_lines = defaults_section.get("timeout", [])
+
+    # Extract client and server timeout values from the parsed "timeout" entries
+    timeout_values = {}
+    for tline in timeout_lines:
+        tline = tline.strip()
+        if not tline:
+            continue
+        parts = tline.split(None, 1)
+        if len(parts) < 2:
+            continue
+        kind, value = parts[0].strip(), parts[1].strip()
+        if kind in ("client", "server"):
+            timeout_values[kind] = value
+
+    # Special handling for idletimeout == 0: there should be no client/server timeouts configured
+    if idle_value == "0":
+        if "client" in timeout_values or "server" in timeout_values:
+            print("defaults timeout client or timeout server should be absent when idletimeout is 0")
             return False
+        return True
+
+    # Non-zero idletimeout: both client and server timeouts must be present
+    if "client" not in timeout_values or "server" not in timeout_values:
+        print("defaults timeout client or timeout server missing")
+        return False
 
+    if idle_value != timeout_values["client"] or idle_value != timeout_values["server"]:
+        print("defaults timeout client or timeout server mismatch occurred")
+        return False
     return True
 
 def checkLoadBalance(haproxyData, haCfgSections):