CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume

Update the volume id in volume_store_ref table to newly created volume for migration

Author: anshulgangwar

engine/schema/src/org/apache/cloudstack/storage/datastore/db/VolumeDataStoreDao.java

@@ -51,4 +51,6 @@ public interface VolumeDataStoreDao extends GenericDao<VolumeDataStoreVO, Long>,
     List<VolumeDataStoreVO> listUploadedVolumesByStoreId(long id);
 
     List<VolumeDataStoreVO> listByVolumeState(Volume.State... states);
+
+    boolean updateVolumeId(long srcVolId, long destVolId);
 }

engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java

@@ -25,6 +25,7 @@
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import com.cloud.utils.exception.CloudRuntimeException;
 import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 import org.apache.cloudstack.engine.subsystem.api.storage.DataObjectInStore;
@@ -350,4 +351,20 @@ public List<VolumeDataStoreVO> listByVolumeState(Volume.State... states) {
         return listIncludingRemovedBy(sc);
     }
 
+    @Override
+    public boolean updateVolumeId(long srcVolId, long destVolId) {
+        TransactionLegacy txn = TransactionLegacy.currentTxn();
+        try {
+            VolumeDataStoreVO volumeDataStoreVO = findByVolume(srcVolId);
+            if(volumeDataStoreVO != null) {
+                txn.start();
+                volumeDataStoreVO.setVolumeId(destVolId);
+                update(volumeDataStoreVO.getId(), volumeDataStoreVO);
+                txn.commit();
+            }
+        } catch (Exception e) {
+            throw new CloudRuntimeException("Unable to update the volume id for volume store ref", e);
+        }
+        return true;
+    }
 }

engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

@@ -1423,6 +1423,7 @@ protected Void copyVolumeCallBack(AsyncCallbackDispatcher<VolumeServiceImpl, Cop
             srcVolume.processEvent(Event.OperationSuccessed);
             destVolume.processEvent(Event.MigrationCopySucceeded, result.getAnswer());
             volDao.updateUuid(srcVolume.getId(), destVolume.getId());
+            _volumeStoreDao.updateVolumeId(srcVolume.getId(), destVolume.getId());
             try {
                 destroyVolume(srcVolume.getId());
                 srcVolume = volFactory.getVolume(srcVolume.getId());