Skip to content

Commit 2df33d3

Browse files
chore: remove XFAIL from passing tests (#884)
* remove xfail from passing tests * update xfail cmoment for datetime_s * document upstream issue for timestamp[s] xfail test
1 parent 8b36aac commit 2df33d3

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

python/datafusion/tests/test_sql.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -378,23 +378,29 @@ def test_udf(
378378
helpers.data_binary_other(),
379379
helpers.data_date32(),
380380
helpers.data_with_nans(),
381-
# C data interface missing
382381
pytest.param(
383382
pa.array([b"1111", b"2222", b"3333"], pa.binary(4), _null_mask),
384383
id="binary4",
385-
marks=pytest.mark.xfail,
386384
),
385+
# `timestamp[s]` does not roundtrip for pyarrow.parquet: https://github.com/apache/arrow/issues/41382
387386
pytest.param(
388-
helpers.data_datetime("s"), id="datetime_s", marks=pytest.mark.xfail
387+
helpers.data_datetime("s"),
388+
id="datetime_s",
389+
marks=pytest.mark.xfail(
390+
reason="pyarrow.parquet does not support timestamp[s] roundtrips"
391+
),
389392
),
390393
pytest.param(
391-
helpers.data_datetime("ms"), id="datetime_ms", marks=pytest.mark.xfail
394+
helpers.data_datetime("ms"),
395+
id="datetime_ms",
392396
),
393397
pytest.param(
394-
helpers.data_datetime("us"), id="datetime_us", marks=pytest.mark.xfail
398+
helpers.data_datetime("us"),
399+
id="datetime_us",
395400
),
396401
pytest.param(
397-
helpers.data_datetime("ns"), id="datetime_ns", marks=pytest.mark.xfail
402+
helpers.data_datetime("ns"),
403+
id="datetime_ns",
398404
),
399405
# Not writtable to parquet
400406
pytest.param(

0 commit comments

Comments
 (0)