Add GitHub cpp-linter-action

Author: wgtmac

.github/workflows/cpp-linter.yml

@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: pre-commit
+
+on:
+  pull_request:
+  push:
+    branches:
+      - '**'
+      - '!dependabot/**'
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-24.04
+    steps:
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
+    - uses: pre-commit/action@v3.0.1

.github/workflows/license_check.yml

@@ -16,6 +16,7 @@
 # under the License.
 
 name: "Run License Check"
+
 on: pull_request
 
 jobs:

.github/workflows/pre-commit.yml

@@ -15,19 +15,37 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: pre-commit
+name: C++ Linter
 
 on:
   pull_request:
-  push:
+    paths-ignore:
+      - '.github/**'
+      - 'ci/**'
+      - 'cmake_modules/**'
     branches:
-      - '**'
-      - '!dependabot/**'
+      - main
 
 jobs:
-  pre-commit:
+  cpp-linter:
     runs-on: ubuntu-24.04
     steps:
-    - uses: actions/checkout@v4
-    - uses: actions/setup-python@v5
-    - uses: pre-commit/action@v3.0.1
+      - uses: actions/checkout@v4
+      - uses: cpp-linter/cpp-linter-action@v2.13.3
+        id: linter
+        continue-on-error: true
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          style: file
+          tidy-checks: file
+          files-changed-only: true
+          lines-changed-only: true
+          thread-comments: true
+          ignore: 'build|cmake_modules|ci'
+          database: build/compile_commands.json
+      - name: Fail fast?!
+        if: steps.linter.outputs.checks-failed != 0
+        run: |
+          echo "some linter checks failed. ${{ steps.linter.outputs.checks-failed }}"
+          exit 1

api/iceberg/table.h

@@ -20,15 +20,19 @@
 #pragma once
 
 #include <memory>
-#include <string_view>
+  #include <string_view>
 
 namespace iceberg {
 
 class Table {
- public:
-  virtual ~Table() = default;
-  virtual std::string_view print() const = 0;
+public:
+
+  virtual ~Table(    ) = default;
+  virtual std::string_view print()
+  
+     const = 0;
   static std::unique_ptr<Table> create();
-};
+
+} ;
 
 }  // namespace iceberg