Skip to content

Commit 5cae029

Browse files
committed
fix: apply clang-format and use default member initializers
- Use default member initializers in MockFileWriter - Fix include ordering per clang-format - Fix line wrapping in comments and assertions
1 parent 657f22f commit 5cae029

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/iceberg/data/writer.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ namespace iceberg {
4949
///
5050
/// \note This interface uses PascalCase method naming (Write, Length, Close, Metadata)
5151
/// to distinguish it from the lower-level iceberg/file_writer.h::Writer interface which
52-
/// uses lowercase naming. FileWriter is the Iceberg-specific data file writer abstraction,
53-
/// while Writer is the file format-level abstraction.
52+
/// uses lowercase naming. FileWriter is the Iceberg-specific data file writer
53+
/// abstraction, while Writer is the file format-level abstraction.
5454
class ICEBERG_EXPORT FileWriter {
5555
public:
5656
virtual ~FileWriter() = default;

src/iceberg/test/data_writer_test.cc

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,14 @@
1717
* under the License.
1818
*/
1919

20-
#include "iceberg/data/writer.h"
21-
2220
#include <memory>
2321
#include <vector>
2422

2523
#include <gmock/gmock.h>
2624
#include <gtest/gtest.h>
2725

2826
#include "iceberg/arrow_c_data.h"
27+
#include "iceberg/data/writer.h"
2928
#include "iceberg/manifest/manifest_entry.h"
3029
#include "iceberg/result.h"
3130
#include "iceberg/test/matchers.h"
@@ -35,7 +34,7 @@ namespace iceberg {
3534
// Mock implementation of FileWriter for testing
3635
class MockFileWriter : public FileWriter {
3736
public:
38-
MockFileWriter() : bytes_written_(0), is_closed_(false), write_count_(0) {}
37+
MockFileWriter() = default;
3938

4039
Status Write(ArrowArray* data) override {
4140
if (is_closed_) {
@@ -80,9 +79,9 @@ class MockFileWriter : public FileWriter {
8079
int32_t write_count() const { return write_count_; }
8180

8281
private:
83-
int64_t bytes_written_;
84-
bool is_closed_;
85-
int32_t write_count_;
82+
int64_t bytes_written_ = 0;
83+
bool is_closed_ = false;
84+
int32_t write_count_ = 0;
8685
};
8786

8887
TEST(FileWriterTest, BasicWriteOperation) {
@@ -158,7 +157,8 @@ TEST(FileWriterTest, MetadataBeforeClose) {
158157
ASSERT_THAT(writer.Write(&dummy_array), IsOk());
159158

160159
auto metadata_result = writer.Metadata();
161-
ASSERT_THAT(metadata_result, HasErrorMessage("Writer must be closed before getting metadata"));
160+
ASSERT_THAT(metadata_result,
161+
HasErrorMessage("Writer must be closed before getting metadata"));
162162
}
163163

164164
TEST(FileWriterTest, MetadataAfterClose) {
@@ -183,7 +183,7 @@ TEST(FileWriterTest, MetadataAfterClose) {
183183
const auto& data_file = result.data_files[0];
184184
ASSERT_EQ(data_file->file_path, "/test/data/file.parquet");
185185
ASSERT_EQ(data_file->file_format, FileFormatType::kParquet);
186-
ASSERT_EQ(data_file->record_count, 300); // 3 writes * 100 records
186+
ASSERT_EQ(data_file->record_count, 300); // 3 writes * 100 records
187187
ASSERT_EQ(data_file->file_size_in_bytes, 3072); // 3 * 1024
188188
}
189189

0 commit comments

Comments
 (0)