Skip to content

Commit 9504b88

Browse files
gty404wgtmac
andauthored
Apply suggestions from code review
remove duplicated apis Co-authored-by: Gang Wu <ustcwg@gmail.com>
1 parent 85b52a3 commit 9504b88

File tree

1 file changed

+2
-48
lines changed

1 file changed

+2
-48
lines changed

src/iceberg/update/update_schema.h

Lines changed: 2 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -112,26 +112,6 @@ class ICEBERG_EXPORT UpdateSchema : public PendingUpdate {
112112
UpdateSchema& AddColumn(std::optional<std::string_view> parent, std::string_view name,
113113
std::shared_ptr<Type> type, std::string_view doc = "");
114114

115-
/// \brief Add a new required top-level column.
116-
///
117-
/// Adding a required column without a default is an incompatible change that can
118-
/// break reading older data. To suppress exceptions thrown when an incompatible
119-
/// change is detected, call AllowIncompatibleChanges().
120-
///
121-
/// Because "." may be interpreted as a column path separator or may be used in
122-
/// field names, it is not allowed in names passed to this method. To add to nested
123-
/// structures or to add fields with names that contain ".", use
124-
/// AddRequiredColumn(parent, name, type).
125-
///
126-
/// If type is a nested type, its field IDs are reassigned when added to the
127-
/// existing schema.
128-
///
129-
/// \param name Name for the new column.
130-
/// \param type Type for the new column.
131-
/// \return Reference to this for method chaining.
132-
/// \note InvalidArgument will be reported if name contains ".".
133-
UpdateSchema& AddRequiredColumn(std::string_view name, std::shared_ptr<Type> type);
134-
135115
/// \brief Add a new required top-level column with documentation.
136116
///
137117
/// Adding a required column without a default is an incompatible change that can
@@ -152,33 +132,7 @@ class ICEBERG_EXPORT UpdateSchema : public PendingUpdate {
152132
/// \return Reference to this for method chaining.
153133
/// \note InvalidArgument will be reported if name contains ".".
154134
UpdateSchema& AddRequiredColumn(std::string_view name, std::shared_ptr<Type> type,
155-
std::string_view doc);
156-
157-
/// \brief Add a new required column to a nested struct.
158-
///
159-
/// Adding a required column without a default is an incompatible change that can
160-
/// break reading older data. To suppress exceptions thrown when an incompatible
161-
/// change is detected, call AllowIncompatibleChanges().
162-
///
163-
/// The parent name is used to find the parent using Schema::FindFieldByName(). If
164-
/// the parent name is null or empty, the new column will be added to the root as a
165-
/// top-level column. If parent identifies a struct, a new column is added to that
166-
/// struct. If it identifies a list, the column is added to the list element struct,
167-
/// and if it identifies a map, the new column is added to the map's value struct.
168-
///
169-
/// The given name is used to name the new column and names containing "." are not
170-
/// handled differently.
171-
///
172-
/// If type is a nested type, its field IDs are reassigned when added to the
173-
/// existing schema.
174-
///
175-
/// \param parent Name of the parent struct to which the column will be added.
176-
/// \param name Name for the new column.
177-
/// \param type Type for the new column.
178-
/// \return Reference to this for method chaining.
179-
/// \note InvalidArgument will be reported if parent doesn't identify a struct.
180-
UpdateSchema& AddRequiredColumn(std::optional<std::string_view> parent,
181-
std::string_view name, std::shared_ptr<Type> type);
135+
std::string_view doc = "");
182136

183137
/// \brief Add a new required column to a nested struct with documentation.
184138
///
@@ -206,7 +160,7 @@ class ICEBERG_EXPORT UpdateSchema : public PendingUpdate {
206160
/// \note InvalidArgument will be reported if parent doesn't identify a struct.
207161
UpdateSchema& AddRequiredColumn(std::optional<std::string_view> parent,
208162
std::string_view name, std::shared_ptr<Type> type,
209-
std::string_view doc);
163+
std::string_view doc = "");
210164

211165
/// \brief Rename a column in the schema.
212166
///

0 commit comments

Comments
 (0)