Set the ManifestEntryStatus

Fokko · Fokko · commit 1d1a68d174c6 · 2025-09-01T13:03:14.000+02:00
A faulty refactor: 59742e0#diff-e9df836e263024ba54e2706853fb25c00269fbfe3726b440ba57f4a929c995dcR927 This produces incorrect metadata, but was hidden by the writer.
diff --git a/pyiceberg/manifest.py b/pyiceberg/manifest.py
@@ -1090,7 +1090,10 @@ def add(self, entry: ManifestEntry) -> ManifestWriter:
         if entry.sequence_number is not None and entry.sequence_number >= 0:
             self.add_entry(
                 ManifestEntry.from_args(
-                    snapshot_id=self._snapshot_id, sequence_number=entry.sequence_number, data_file=entry.data_file
+                    status=ManifestEntryStatus.ADDED,
+                    snapshot_id=self._snapshot_id,
+                    sequence_number=entry.sequence_number,
+                    data_file=entry.data_file,
                 )
             )
         else:

Original file line number	Diff line number	Diff line change
`@@ -1090,7 +1090,10 @@ def add(self, entry: ManifestEntry) -> ManifestWriter:`
`1090`	`1090`	`if entry.sequence_number is not None and entry.sequence_number >= 0:`
`1091`	`1091`	`self.add_entry(`
`1092`	`1092`	`ManifestEntry.from_args(`
`1093`		`- snapshot_id=self._snapshot_id, sequence_number=entry.sequence_number, data_file=entry.data_file`
	`1093`	`+ status=ManifestEntryStatus.ADDED,`
	`1094`	`+ snapshot_id=self._snapshot_id,`
	`1095`	`+ sequence_number=entry.sequence_number,`
	`1096`	`+ data_file=entry.data_file,`
`1094`	`1097`	`)`
`1095`	`1098`	`)`
`1096`	`1099`	`else:`