@@ -225,18 +225,18 @@ def test_pyarrow_timestamp_tz_invalid_tz() -> None:
225225 visit_pyarrow (pyarrow_type , _ConvertToIceberg ())
226226
227227
228- def test_pyarrow_string_to_iceberg () -> None :
229- pyarrow_type = pa .large_string ()
228+ @ pytest . mark . parametrize ( "pyarrow_type" , [ pa . string (), pa . large_string (), pa . string_view ()])
229+ def test_pyarrow_string_to_iceberg ( pyarrow_type : pa .DataType ) -> None :
230230 converted_iceberg_type = visit_pyarrow (pyarrow_type , _ConvertToIceberg ())
231231 assert converted_iceberg_type == StringType ()
232- assert visit (converted_iceberg_type , _ConvertToArrowSchema ()) == pyarrow_type
232+ assert visit (converted_iceberg_type , _ConvertToArrowSchema ()) == pa . large_string ()
233233
234234
235- def test_pyarrow_variable_binary_to_iceberg () -> None :
236- pyarrow_type = pa .large_binary ()
235+ @ pytest . mark . parametrize ( "pyarrow_type" , [ pa . binary (), pa . large_binary (), pa . binary_view ()])
236+ def test_pyarrow_variable_binary_to_iceberg ( pyarrow_type : pa .DataType ) -> None :
237237 converted_iceberg_type = visit_pyarrow (pyarrow_type , _ConvertToIceberg ())
238238 assert converted_iceberg_type == BinaryType ()
239- assert visit (converted_iceberg_type , _ConvertToArrowSchema ()) == pyarrow_type
239+ assert visit (converted_iceberg_type , _ConvertToArrowSchema ()) == pa . large_binary ()
240240
241241
242242def test_pyarrow_struct_to_iceberg () -> None :
0 commit comments