Skip to content

Commit 539460a

Browse files
committed
fix tests
1 parent 20cbd51 commit 539460a

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

pyiceberg/table/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,7 +957,7 @@ def _initial_changes(self, table_metadata: TableMetadata) -> None:
957957

958958
schema: Schema = table_metadata.schema()
959959
self._updates += (
960-
AddSchemaUpdate(schema_=schema, last_column_id=schema.highest_field_id),
960+
AddSchemaUpdate(schema_=schema),
961961
SetCurrentSchemaUpdate(schema_id=-1),
962962
)
963963

pyiceberg/table/update/schema.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -629,9 +629,8 @@ def _commit(self) -> UpdatesAndRequirements:
629629
if existing_schema_id != self._schema.schema_id:
630630
requirements += (AssertCurrentSchemaId(current_schema_id=self._schema.schema_id),)
631631
if existing_schema_id is None:
632-
last_column_id = max(self._transaction.table_metadata.last_column_id, new_schema.highest_field_id)
633632
updates += (
634-
AddSchemaUpdate(schema=new_schema, last_column_id=last_column_id),
633+
AddSchemaUpdate(schema=new_schema),
635634
SetCurrentSchemaUpdate(schema_id=-1),
636635
)
637636
else:

tests/catalog/test_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ def test_commit_table(catalog: InMemoryCatalog) -> None:
486486
response = given_table.catalog.commit_table(
487487
given_table,
488488
updates=(
489-
AddSchemaUpdate(schema=new_schema, last_column_id=new_schema.highest_field_id),
489+
AddSchemaUpdate(schema=new_schema),
490490
SetCurrentSchemaUpdate(schema_id=-1),
491491
),
492492
requirements=(),

tests/catalog/test_rest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1122,7 +1122,6 @@ def test_create_staged_table_200(
11221122
"schema-id": 0,
11231123
"identifier-field-ids": [],
11241124
},
1125-
"last-column-id": 2,
11261125
},
11271126
{"action": "set-current-schema", "schema-id": -1},
11281127
{"action": "add-spec", "spec": {"spec-id": 0, "fields": []}},

0 commit comments

Comments
 (0)