adding test

Author: rambleraptor

pyiceberg/view/metadata.py

@@ -16,12 +16,12 @@
 # under the License.
 from __future__ import annotations
 
-from typing import Dict, List, Literal, Optional
+from typing import Dict, List, Literal, Optional, Union
 
 from pydantic import Field, field_validator
 
 from pyiceberg.schema import Schema
-from pyiceberg.typedef import IcebergBaseModel, Properties
+from pyiceberg.typedef import IcebergBaseModel, Identifier, Properties
 from pyiceberg.types import transform_dict_value_to_str
 
 
@@ -36,10 +36,10 @@ class SQLViewRepresentation(IcebergBaseModel):
     """The dialect of the SQL, e.g. `spark`, `trino`, `presto`."""
 
 
-class ViewRepresentation(BaseModel):
+class ViewRepresentation(IcebergBaseModel):
     __root__: SQLViewRepresentation
-    
-    
+
+
 class ViewVersion(IcebergBaseModel):
     """A version of the view definition."""
 
@@ -51,11 +51,11 @@ class ViewVersion(IcebergBaseModel):
     """Timestamp when the version was created (ms from epoch)"""
     summary: Dict[str, str] = Field()
     """A string to string map of summary metadata about the version"""
-    representations: List[SQLViewRepresentation] = Field()
+    representations: List[ViewRepresentation] = Field()
     """A list of representations for the view definition"""
     default_catalog: Optional[str] = Field(alias="default-catalog", default=None)
     """Catalog name to use when a reference in the SELECT does not contain a catalog"""
-    default_namespace: Namespace = Field(alias="default-namespace")
+    default_namespace: Union[str, Identifier] = Field(alias="default-namespace")
     """Namespace to use when a reference in the SELECT is a single identifier"""
 
 
@@ -73,7 +73,7 @@ class ViewMetadata(IcebergBaseModel):
 
     view_uuid: str = Field(alias="view-uuid")
     """A UUID that identifies the view, generated when the view is created."""
-    format_version: int = Field(alias='format-version', ge=1, le=1)
+    format_version: int = Field(alias="format-version", ge=1, le=1)
     """An integer version number for the view format; must be 1"""
     location: str = Field()
     """The view's base location; used to create metadata file locations"""
@@ -83,7 +83,7 @@ class ViewMetadata(IcebergBaseModel):
     """ID of the current version of the view (version-id)"""
     versions: List[ViewVersion] = Field()
     """A list of known versions of the view"""
-    version_log: List[ViewVersionLogEntry] = Field(alias="version-log")
+    version_log: List[ViewHistoryEntry] = Field(alias="version-log")
     """A list of version log entries"""
     properties: Properties = Field(default_factory=dict)
     """A string to string map of view properties"""

tests/integration/test_writes/test_writes.py

@@ -59,6 +59,7 @@
     NestedField,
     StringType,
 )
+from pyiceberg.view.metadata import SQLViewRepresentation, ViewVersion
 from utils import _create_table
 
 
@@ -1519,6 +1520,45 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab
     session_catalog.drop_table(identifier)
 
 
+@pytest.mark.integration
+def test_create_view(
+    spark: SparkSession,
+    session_catalog: Catalog,
+) -> None:
+    # Create a view using the REST Catalog.
+    identifier = "default.some_view"
+    schema = pa.schema([pa.field("some_col", pa.int32())])
+    view_version = ViewVersion(
+        version_id=1,
+        schema_id=1,
+        timestamp_ms=int(time.time() * 1000),
+        summary={},
+        representations=[
+            SQLViewRepresentation(
+                type="sql",
+                sql="SELECT 1 as some_col",
+                dialect="spark",
+            )
+        ],
+        default_namespace="default",
+    )
+    session_catalog.create_view(
+        identifier=identifier,
+        schema=schema,
+        view_version=view_version,
+    )
+
+    # Ensure the view exists.
+    assert session_catalog.view_exists(identifier)
+
+    # Query the view in spark to ensure it was properly created.
+    df = spark.table(identifier)
+    assert df.count() == 1
+    assert df.collect()[0].some_col == 1
+
+    session_catalog.drop_view(identifier)  # clean up
+
+
 @pytest.mark.integration
 def test_view_exists(
     spark: SparkSession,