fix: Use keyword argument for RemoveStatisticsUpdate instantiation

ForeverAngry · ForeverAngry · commit 8c1dcd6e36ff · 2025-11-03T20:59:35.000-05:00
Fixes #2558 When removing snapshots with statistics, RemoveStatisticsUpdate was being instantiated with a positional argument, which violates Pydantic's BaseModel requirement that all fields be passed as keyword arguments. This caused a TypeError: BaseModel.__init__() takes 1 positional argument but 2 were given when calling table.maintenance.expire_snapshots(). Changed from: RemoveStatisticsUpdate(statistics_file.snapshot_id) To: RemoveStatisticsUpdate(snapshot_id=statistics_file.snapshot_id) All existing tests pass with this fix.
diff --git a/pyiceberg/table/update/__init__.py b/pyiceberg/table/update/__init__.py
@@ -530,7 +530,7 @@ def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _Tab
         if ref.snapshot_id in update.snapshot_ids
     )
     remove_statistics_updates = (
-        RemoveStatisticsUpdate(statistics_file.snapshot_id)
+        RemoveStatisticsUpdate(snapshot_id=statistics_file.snapshot_id)
         for statistics_file in base_metadata.statistics
         if statistics_file.snapshot_id in update.snapshot_ids
     )

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _Tab`
`530`	`530`	`if ref.snapshot_id in update.snapshot_ids`
`531`	`531`	`)`
`532`	`532`	`remove_statistics_updates = (`
`533`		`- RemoveStatisticsUpdate(statistics_file.snapshot_id)`
	`533`	`+ RemoveStatisticsUpdate(snapshot_id=statistics_file.snapshot_id)`
`534`	`534`	`for statistics_file in base_metadata.statistics`
`535`	`535`	`if statistics_file.snapshot_id in update.snapshot_ids`
`536`	`536`	`)`