Remove entries from snapshot log

Author: grihabor

pyiceberg/table/update/__init__.py

@@ -469,6 +469,11 @@ def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _Tab
         for s in base_metadata.snapshots
         if s.snapshot_id not in update.snapshot_ids
     ]
+    snapshot_log = [
+        snapshot_log_entry
+        for snapshot_log_entry in base_metadata.snapshot_log
+        if snapshot_log_entry.snapshot_id not in update.snapshot_ids
+    ]
 
     remove_ref_updates = (
         RemoveSnapshotRefUpdate(ref_name=ref_name)
@@ -486,7 +491,7 @@ def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _Tab
         new_metadata = _apply_table_update(upd, new_metadata, context)
 
     context.add_update(update)
-    return new_metadata.model_copy(update={"snapshots": snapshots})
+    return new_metadata.model_copy(update={"snapshots": snapshots, "snapshot_log": snapshot_log})
 
 
 @_apply_table_update.register(RemoveSnapshotRefUpdate)

tests/table/test_init.py

@@ -797,6 +797,7 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table) -> None:
 def test_update_remove_snapshots(table_v2: Table) -> None:
     # assert fixture data to easily understand the test assumptions
     assert len(table_v2.metadata.snapshots) == 2
+    assert len(table_v2.metadata.snapshot_log) == 2
     assert len(table_v2.metadata.refs) == 2
     update = RemoveSnapshotsUpdate(snapshot_ids=[3051729675574597004])
     new_metadata = update_table_metadata(table_v2.metadata, (update,))
@@ -805,6 +806,8 @@ def test_update_remove_snapshots(table_v2: Table) -> None:
     assert new_metadata.snapshots[0].parent_snapshot_id is None
     assert new_metadata.current_snapshot_id == 3055729675574597004
     assert new_metadata.last_updated_ms > table_v2.metadata.last_updated_ms
+    assert len(new_metadata.snapshot_log) == 1
+    assert new_metadata.snapshot_log[0].snapshot_id == 3055729675574597004
     assert len(new_metadata.refs) == 1
     assert new_metadata.refs["main"].snapshot_id == 3055729675574597004