fix if statment

Author: amitgilad3

pyiceberg/io/pyarrow.py

@@ -906,9 +906,9 @@ def _read_delete_file(fs: FileSystem, data_file: DataFile) -> Iterator[PositionD
 def _read_deletes(fs: FileSystem, data_file: DataFile) -> Dict[str, pa.ChunkedArray]:
     deletes_by_file: Dict[str, List[int]] = {}
     for delete in _read_delete_file(fs, data_file):
-        if delete.file_path not in deletes_by_file:
-            deletes_by_file[delete.file_path] = []
-        deletes_by_file[delete.file_path].append(delete.pos)
+        if delete.path not in deletes_by_file:
+            deletes_by_file[delete.path] = []
+        deletes_by_file[delete.path].append(delete.pos)
 
     # Convert lists of positions to ChunkedArrays
     return {

pyiceberg/manifest.py

@@ -322,7 +322,7 @@ def data_file_with_partition(partition_type: StructType, format_version: TableVe
 
 class PositionDelete(Record):
     __slots__ = ("file_path", "pos", "row")
-    file_path: str
+    path: str
     pos: int
     row: Optional[Record]
 
@@ -332,20 +332,20 @@ def __setattr__(self, name: str, value: Any) -> None:
 
     def __init__(self, file_path: str, pos: int, row: Optional[Record], *data: Any, **named_data: Any) -> None:
         super().__init__(*data, **named_data)
-        self.file_path = file_path
+        self.path = file_path
         self.pos = pos
         self.row = row
 
     def __hash__(self) -> int:
         """Return the hash of the file path."""
-        return hash(self.file_path)
+        return hash(self.path)
 
     def __eq__(self, other: Any) -> bool:
         """Compare the PositionDelete with another object.
 
         If it is a PositionDelete, it will compare based on the file_path.
         """
-        return self.file_path == other.file_path if isinstance(other, PositionDelete) else False
+        return self.path == other.path if isinstance(other, PositionDelete) else False
 
 
 class DataFile(Record):

pyiceberg/table/inspect.py

@@ -494,7 +494,7 @@ def _generate_positional_delete_table(self, manifest: ManifestFile, schema: Sche
                     positional_deletes_records = []
                     for record in positional_delete_file:
                         row = {
-                            "file_path": record.file_path,
+                            "file_path": record.path,
                             "pos": record.pos,
                             "row": record.row,
                             "partition": entry.data_file.partition.__dict__,
@@ -722,7 +722,7 @@ def position_deletes(self, snapshot_id: Optional[int] = None) -> "pa.Table":
             schema = self._get_positional_deletes_schema()
             return pa.Table.from_pylist([], schema=schema)
 
-        if not snapshot.schema_id:
+        if snapshot.schema_id == None:
             raise ValueError(f"Snapshot {snapshot.snapshot_id} does not have a schema id")
 
         schemas = self.tbl.schemas()