Cleanup

Author: Fokko

pyiceberg/io/pyarrow.py

@@ -1753,8 +1753,6 @@ def _cast_if_needed(self, field: NestedField, values: pa.Array) -> pa.Array:
                         elif target_type.unit == "us" and values.type.unit in {"s", "ms", "us"}:
                             return values.cast(target_type)
                     raise ValueError(f"Unsupported schema projection from {values.type} to {target_type}")
-                else:
-                    pass
         return values
 
     def _construct_field(self, field: NestedField, arrow_type: pa.DataType) -> pa.Field:

tests/integration/test_writes/test_writes.py

@@ -1780,40 +1780,6 @@ def test_write_optional_list(session_catalog: Catalog) -> None:
     assert len(session_catalog.load_table(identifier).scan().to_arrow()) == 4
 
 
-@pytest.mark.integration
-@pytest.mark.parametrize("format_version", [1, 2])
-def test_evolve_and_write(
-    spark: SparkSession, session_catalog: Catalog, arrow_table_with_null: pa.Table, format_version: int
-) -> None:
-    identifier = "default.test_evolve_and_write"
-    tbl = _create_table(session_catalog, identifier, properties={"format-version": format_version}, schema=Schema())
-    other_table = session_catalog.load_table(identifier)
-
-    numbers = pa.array([1, 2, 3, 4], type=pa.int32())
-
-    with tbl.update_schema() as upd:
-        # This is not known by other_table
-        upd.add_column("id", IntegerType())
-
-    with other_table.transaction() as tx:
-        # Refreshes the underlying metadata, and the schema
-        other_table.refresh()
-        tx.append(
-            pa.Table.from_arrays(
-                [
-                    numbers,
-                ],
-                schema=pa.schema(
-                    [
-                        pa.field("id", pa.int32(), nullable=True),
-                    ]
-                ),
-            )
-        )
-
-    assert session_catalog.load_table(identifier).scan().to_arrow().column(0).combine_chunks() == numbers
-
-
 @pytest.mark.integration
 def test_read_write_decimals(session_catalog: Catalog) -> None:
     """Roundtrip decimal types to make sure that we correctly write them as ints"""