thx drew

Author: kevinjqliu

pyiceberg/catalog/__init__.py

@@ -286,8 +286,7 @@ def delete_files(io: FileIO, files_to_delete: set[str], file_type: str) -> None:
         try:
             io.delete(file)
         except OSError as exc:
-            logger.warning(msg=f"Failed to delete {file_type} file {file}")
-            logger.debug(f"Error deleting {file_type} file {file}", exc_info=exc)
+            logger.warning(f"Failed to delete {file_type} file {file}", exc_info=exc if logger.isEnabledFor(logging.DEBUG) else None)
 
 
 def delete_data_files(io: FileIO, manifests_to_delete: list[ManifestFile]) -> None:
@@ -307,8 +306,7 @@ def delete_data_files(io: FileIO, manifests_to_delete: list[ManifestFile]) -> No
                 try:
                     io.delete(path)
                 except OSError as exc:
-                    logger.warning(msg=f"Failed to delete data file {path}")
-                    logger.debug(f"Error deleting data file {path}", exc_info=exc)
+                    logger.warning(f"Failed to delete data file {path}", exc_info=exc if logger.isEnabledFor(logging.DEBUG) else None)
                 deleted_files[path] = True
 
 
@@ -322,8 +320,7 @@ def _import_catalog(name: str, catalog_impl: str, properties: Properties) -> Cat
         class_ = getattr(module, class_name)
         return class_(name, **properties)
     except ModuleNotFoundError as exc:
-        logger.warning(f"Could not initialize Catalog: {catalog_impl}")
-        logger.debug(f"Failed to load {catalog_impl}", exc_info=exc)
+        logger.warning(f"Could not initialize Catalog: {catalog_impl}", exc_info=exc if logger.isEnabledFor(logging.DEBUG) else None)
         return None
 
 

pyiceberg/io/__init__.py

@@ -322,8 +322,7 @@ def _import_file_io(io_impl: str, properties: Properties) -> FileIO | None:
         class_ = getattr(module, class_name)
         return class_(properties)
     except ModuleNotFoundError as exc:
-        logger.warning(f"Could not initialize FileIO: {io_impl}")
-        logger.debug(f"Failed to load {io_impl}", exc_info=exc)
+        logger.warning(f"Could not initialize FileIO: {io_impl}", exc_info=exc if logger.isEnabledFor(logging.DEBUG) else None)
         return None
 
 

pyiceberg/table/locations.py

@@ -179,8 +179,7 @@ def _import_location_provider(
         class_ = getattr(module, class_name)
         return class_(table_location, table_properties)
     except ModuleNotFoundError as exc:
-        logger.warning(f"Could not initialize LocationProvider: {location_provider_impl}")
-        logger.debug(f"Failed to load {location_provider_impl}", exc_info=exc)
+        logger.warning(f"Could not initialize LocationProvider: {location_provider_impl}", exc_info=exc if logger.isEnabledFor(logging.DEBUG) else None)
         return None