Skip to content

Commit f25f406

Browse files
author
Yingjian Wu
committed
address comments
1 parent 0bf0e8b commit f25f406

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

pyiceberg/table/snapshots.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,9 @@ def __init__(self, partition_summary_limit: int = 0) -> None:
277277
self.partition_metrics = defaultdict(UpdateMetrics)
278278
self.max_changed_partitions_for_summaries = partition_summary_limit
279279

280+
def set_partition_summary_limit(self, limit: int) -> None:
281+
self.max_changed_partitions_for_summaries = limit
282+
280283
def add_file(self, data_file: DataFile, schema: Schema, partition_spec: PartitionSpec = UNPARTITIONED_PARTITION_SPEC) -> None:
281284
self.metrics.add_file(data_file)
282285
if len(data_file.partition) > 0:

tests/table/test_snapshots.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,22 @@ def test_snapshot_summary_collector_with_partition() -> None:
201201
"changed-partition-count": "2",
202202
}
203203

204+
# When
205+
ssc.set_partition_summary_limit(10)
206+
207+
# Then
208+
assert ssc.build() == {
209+
"added-files-size": "1234",
210+
"removed-files-size": "5555",
211+
"added-data-files": "1",
212+
"deleted-data-files": "2",
213+
"added-records": "100",
214+
"deleted-records": "300",
215+
"changed-partition-count": "2",
216+
"partitions.int_field=1": "added-files-size=1234,removed-files-size=1234,added-data-files=1,deleted-data-files=1,added-records=100,deleted-records=100",
217+
"partitions.int_field=2": "removed-files-size=4321,deleted-data-files=1,deleted-records=200",
218+
}
219+
204220

205221
@pytest.mark.integration
206222
def test_snapshot_summary_collector_with_partition_limit_in_constructor() -> None:

0 commit comments

Comments
 (0)