Skip to content

Commit f4e2a61

Browse files
committed
add abstract methods to additional classes
1 parent c91afad commit f4e2a61

File tree

5 files changed

+15
-0
lines changed

5 files changed

+15
-0
lines changed

pyiceberg/catalog/dynamodb.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -547,6 +547,9 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None:
547547
def view_exists(self, identifier: Union[str, Identifier]) -> bool:
548548
raise NotImplementedError
549549

550+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
551+
raise NotImplementedError
552+
550553
def _get_iceberg_table_item(self, database_name: str, table_name: str) -> Dict[str, Any]:
551554
try:
552555
return self._get_dynamo_item(identifier=f"{database_name}.{table_name}", namespace=database_name)

pyiceberg/catalog/glue.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -818,6 +818,9 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None:
818818
def view_exists(self, identifier: Union[str, Identifier]) -> bool:
819819
raise NotImplementedError
820820

821+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
822+
raise NotImplementedError
823+
821824
@staticmethod
822825
def __is_iceberg_table(table: "TableTypeDef") -> bool:
823826
return table.get("Parameters", {}).get(TABLE_TYPE, "").lower() == ICEBERG

pyiceberg/catalog/hive.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,9 @@ def list_views(self, namespace: Union[str, Identifier]) -> List[Identifier]:
475475
def view_exists(self, identifier: Union[str, Identifier]) -> bool:
476476
raise NotImplementedError
477477

478+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
479+
raise NotImplementedError
480+
478481
def _create_lock_request(self, database_name: str, table_name: str) -> LockRequest:
479482
lock_component: LockComponent = LockComponent(
480483
level=LockLevel.TABLE, type=LockType.EXCLUSIVE, dbname=database_name, tablename=table_name, isTransactional=True

pyiceberg/catalog/noop.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,3 +128,6 @@ def view_exists(self, identifier: Union[str, Identifier]) -> bool:
128128

129129
def drop_view(self, identifier: Union[str, Identifier]) -> None:
130130
raise NotImplementedError
131+
132+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
133+
raise NotImplementedError

pyiceberg/catalog/sql.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -730,3 +730,6 @@ def view_exists(self, identifier: Union[str, Identifier]) -> bool:
730730

731731
def drop_view(self, identifier: Union[str, Identifier]) -> None:
732732
raise NotImplementedError
733+
734+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
735+
raise NotImplementedError

0 commit comments

Comments
 (0)