Skip to content

Commit f99171c

Browse files
committed
remove file size checks
1 parent 74d1393 commit f99171c

File tree

2 files changed

+18
-19
lines changed

2 files changed

+18
-19
lines changed

tests/integration/test_writes/test_partitioned_writes.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -451,11 +451,6 @@ def test_dynamic_partition_overwrite_unpartitioned_evolve_to_identity_transform(
451451

452452
@pytest.mark.integration
453453
def test_summaries_with_null(spark: SparkSession, session_catalog: Catalog, arrow_table_with_null: pa.Table) -> None:
454-
import pyarrow
455-
from packaging import version
456-
457-
under_20_arrow = version.parse(pyarrow.__version__) < version.parse("20.0.0")
458-
459454
identifier = "default.arrow_table_summaries"
460455

461456
try:
@@ -551,27 +546,31 @@ def test_summaries_with_null(spark: SparkSession, session_catalog: Catalog, arro
551546
"total-data-files": "6",
552547
"total-records": "6",
553548
}
549+
assert "removed-files-size" in summaries[5]
550+
assert "total-files-size" in summaries[5]
554551
assert summaries[5] == {
555-
"removed-files-size": "15774" if under_20_arrow else "16174",
552+
"removed-files-size": summaries[5]["removed-files-size"],
556553
"changed-partition-count": "2",
557554
"total-equality-deletes": "0",
558555
"deleted-data-files": "4",
559556
"total-position-deletes": "0",
560557
"total-delete-files": "0",
561558
"deleted-records": "4",
562-
"total-files-size": "8684" if under_20_arrow else "8884",
559+
"total-files-size": summaries[5]["total-files-size"],
563560
"total-data-files": "2",
564561
"total-records": "2",
565562
}
563+
assert "added-files-size" in summaries[6]
564+
assert "total-files-size" in summaries[6]
566565
assert summaries[6] == {
567566
"changed-partition-count": "2",
568567
"added-data-files": "2",
569568
"total-equality-deletes": "0",
570569
"added-records": "2",
571570
"total-position-deletes": "0",
572-
"added-files-size": "7887" if under_20_arrow else "8087",
571+
"added-files-size": summaries[6]["added-files-size"],
573572
"total-delete-files": "0",
574-
"total-files-size": "16571" if under_20_arrow else "16971",
573+
"total-files-size": summaries[6]["total-files-size"],
575574
"total-data-files": "4",
576575
"total-records": "4",
577576
}

tests/integration/test_writes/test_writes.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,6 @@ def test_summaries(spark: SparkSession, session_catalog: Catalog, arrow_table_wi
271271

272272
@pytest.mark.integration
273273
def test_summaries_partial_overwrite(spark: SparkSession, session_catalog: Catalog) -> None:
274-
import pyarrow
275-
from packaging import version
276-
277-
under_20_arrow = version.parse(pyarrow.__version__) < version.parse("20.0.0")
278-
279274
identifier = "default.test_summaries_partial_overwrite"
280275
TEST_DATA = {
281276
"id": [1, 2, 3, 1, 1],
@@ -314,15 +309,17 @@ def test_summaries_partial_overwrite(spark: SparkSession, session_catalog: Catal
314309
assert file_size > 0
315310

316311
# APPEND
312+
assert "added-files-size" in summaries[0]
313+
assert "total-files-size" in summaries[0]
317314
assert summaries[0] == {
318315
"added-data-files": "3",
319-
"added-files-size": "2570" if under_20_arrow else "2618",
316+
"added-files-size": summaries[0]["added-files-size"],
320317
"added-records": "5",
321318
"changed-partition-count": "3",
322319
"total-data-files": "3",
323320
"total-delete-files": "0",
324321
"total-equality-deletes": "0",
325-
"total-files-size": "2570" if under_20_arrow else "2618",
322+
"total-files-size": summaries[0]["total-files-size"],
326323
"total-position-deletes": "0",
327324
"total-records": "5",
328325
}
@@ -349,18 +346,21 @@ def test_summaries_partial_overwrite(spark: SparkSession, session_catalog: Catal
349346
# }
350347
files = tbl.inspect.data_files()
351348
assert len(files) == 3
349+
assert "added-files-size" in summaries[1]
350+
assert "removed-files-size" in summaries[1]
351+
assert "total-files-size" in summaries[1]
352352
assert summaries[1] == {
353353
"added-data-files": "1",
354-
"added-files-size": "859" if under_20_arrow else "875",
354+
"added-files-size": summaries[1]["added-files-size"],
355355
"added-records": "2",
356356
"changed-partition-count": "1",
357357
"deleted-data-files": "1",
358358
"deleted-records": "3",
359-
"removed-files-size": "866" if under_20_arrow else "882",
359+
"removed-files-size": summaries[1]["removed-files-size"],
360360
"total-data-files": "3",
361361
"total-delete-files": "0",
362362
"total-equality-deletes": "0",
363-
"total-files-size": "2563" if under_20_arrow else "2611",
363+
"total-files-size": summaries[1]["total-files-size"],
364364
"total-position-deletes": "0",
365365
"total-records": "4",
366366
}

0 commit comments

Comments
 (0)