From b7fe3323a1967a54372538feeed9c9a9872dbcad Mon Sep 17 00:00:00 2001 From: Fokko Date: Sat, 8 Mar 2025 21:08:52 +0100 Subject: [PATCH 1/4] Add pull-request template --- .github/pull_request_template.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..afcc22b98a --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,14 @@ + + + + + +# Rationale for this change + +# Are these changes tested? + +# Are there any user-facing changes? + + From b461488348f97194998775e63d6fe98b3aa9a6f1 Mon Sep 17 00:00:00 2001 From: Fokko Date: Sat, 8 Mar 2025 21:55:49 +0100 Subject: [PATCH 2/4] Exclude from RAT --- dev/.rat-excludes | 1 + 1 file changed, 1 insertion(+) diff --git a/dev/.rat-excludes b/dev/.rat-excludes index e93e25b69e..3475dda5bb 100644 --- a/dev/.rat-excludes +++ b/dev/.rat-excludes @@ -3,3 +3,4 @@ build .git .gitignore poetry.lock +.github/pull_request_template.md From 9c7f1363b5cc1d2cde9cccd5343813de36123d49 Mon Sep 17 00:00:00 2001 From: Fokko Date: Wed, 12 Mar 2025 22:59:13 +0100 Subject: [PATCH 3/4] Does this work? --- dev/.rat-excludes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/.rat-excludes b/dev/.rat-excludes index 3475dda5bb..084c53d2c4 100644 --- a/dev/.rat-excludes +++ b/dev/.rat-excludes @@ -1,6 +1,6 @@ +.github/* .rat-excludes build .git .gitignore poetry.lock -.github/pull_request_template.md From 866f96c1a6035ff7e59aa8c2c7d36656c7125680 Mon Sep 17 00:00:00 2001 From: Fokko Date: Wed, 12 Mar 2025 23:01:07 +0100 Subject: [PATCH 4/4] Update how to guide --- mkdocs/docs/how-to-release.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mkdocs/docs/how-to-release.md b/mkdocs/docs/how-to-release.md index 4af3a212fe..1747c08348 100644 --- a/mkdocs/docs/how-to-release.md +++ b/mkdocs/docs/how-to-release.md @@ -379,6 +379,8 @@ Then, select the previous release version as the **Previous tag** to use the dif **Set as the latest release** and **Publish**. +Make sure to check the `changelog` label on GitHub to see if anything needs to be highlighted. + ### Release the docs Run the [`Release Docs` Github Action](https://github.com/apache/iceberg-python/actions/workflows/python-release-docs.yml).