From 934938534187badd1a28157b46536eebdeed5d58 Mon Sep 17 00:00:00 2001 From: Sreesh Maheshwar Date: Sun, 23 Mar 2025 23:18:17 +0000 Subject: [PATCH] Nit: Introduce `S3_SIGNER` constant property --- pyiceberg/io/__init__.py | 1 + pyiceberg/io/fsspec.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pyiceberg/io/__init__.py b/pyiceberg/io/__init__.py index f4606b6f30..475ae6176b 100644 --- a/pyiceberg/io/__init__.py +++ b/pyiceberg/io/__init__.py @@ -63,6 +63,7 @@ S3_PROXY_URI = "s3.proxy-uri" S3_CONNECT_TIMEOUT = "s3.connect-timeout" S3_REQUEST_TIMEOUT = "s3.request-timeout" +S3_SIGNER = "s3.signer" S3_SIGNER_URI = "s3.signer.uri" S3_SIGNER_ENDPOINT = "s3.signer.endpoint" S3_SIGNER_ENDPOINT_DEFAULT = "v1/aws/s3/sign" diff --git a/pyiceberg/io/fsspec.py b/pyiceberg/io/fsspec.py index 4cbae52304..4342d99401 100644 --- a/pyiceberg/io/fsspec.py +++ b/pyiceberg/io/fsspec.py @@ -67,6 +67,7 @@ S3_REQUEST_TIMEOUT, S3_SECRET_ACCESS_KEY, S3_SESSION_TOKEN, + S3_SIGNER, S3_SIGNER_ENDPOINT, S3_SIGNER_ENDPOINT_DEFAULT, S3_SIGNER_URI, @@ -137,7 +138,7 @@ def _s3(properties: Properties) -> AbstractFileSystem: config_kwargs = {} register_events: Dict[str, Callable[[Properties], None]] = {} - if signer := properties.get("s3.signer"): + if signer := properties.get(S3_SIGNER): logger.info("Loading signer %s", signer) if signer_func := SIGNERS.get(signer): signer_func_with_properties = partial(signer_func, properties)