From 45322015839de4a2523bed9e8296b6d3a0eb5d67 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Mon, 23 Jun 2025 10:40:12 +0200 Subject: [PATCH 1/4] Run `test_create_table_transaction` for Rest V1 tables --- tests/integration/test_writes/test_writes.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/integration/test_writes/test_writes.py b/tests/integration/test_writes/test_writes.py index 493b163b95..728be93645 100644 --- a/tests/integration/test_writes/test_writes.py +++ b/tests/integration/test_writes/test_writes.py @@ -885,11 +885,6 @@ def test_write_and_evolve(session_catalog: Catalog, format_version: int) -> None @pytest.mark.parametrize("format_version", [1, 2]) @pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive"), pytest.lazy_fixture("session_catalog")]) def test_create_table_transaction(catalog: Catalog, format_version: int) -> None: - if format_version == 1 and isinstance(catalog, RestCatalog): - pytest.skip( - "There is a bug in the REST catalog image (https://github.com/apache/iceberg/issues/8756) that prevents create and commit a staged version 1 table" - ) - identifier = f"default.arrow_create_table_transaction_{catalog.name}_{format_version}" try: From ef486e45cb5380170c115e02deb392d7a84332ed Mon Sep 17 00:00:00 2001 From: Fokko Date: Mon, 23 Jun 2025 22:16:20 +0200 Subject: [PATCH 2/4] Remove moar skip's --- tests/integration/test_writes/test_writes.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/integration/test_writes/test_writes.py b/tests/integration/test_writes/test_writes.py index 728be93645..033a9f7c0d 100644 --- a/tests/integration/test_writes/test_writes.py +++ b/tests/integration/test_writes/test_writes.py @@ -40,7 +40,6 @@ from pyiceberg.catalog import Catalog, load_catalog from pyiceberg.catalog.hive import HiveCatalog -from pyiceberg.catalog.rest import RestCatalog from pyiceberg.catalog.sql import SqlCatalog from pyiceberg.exceptions import NoSuchTableError from pyiceberg.expressions import And, EqualTo, GreaterThanOrEqual, In, LessThan, Not @@ -937,11 +936,6 @@ def test_create_table_transaction(catalog: Catalog, format_version: int) -> None @pytest.mark.parametrize("format_version", [1, 2]) @pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive"), pytest.lazy_fixture("session_catalog")]) def test_create_table_with_non_default_values(catalog: Catalog, table_schema_with_all_types: Schema, format_version: int) -> None: - if format_version == 1 and isinstance(catalog, RestCatalog): - pytest.skip( - "There is a bug in the REST catalog image (https://github.com/apache/iceberg/issues/8756) that prevents create and commit a staged version 1 table" - ) - identifier = f"default.arrow_create_table_transaction_with_non_default_values_{catalog.name}_{format_version}" identifier_ref = f"default.arrow_create_table_transaction_with_non_default_values_ref_{catalog.name}_{format_version}" From f78dbf4cbbef471f9dc903b81fdddda6c9f543e0 Mon Sep 17 00:00:00 2001 From: Fokko Date: Mon, 23 Jun 2025 22:18:46 +0200 Subject: [PATCH 3/4] . --- dev/provision.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/provision.py b/dev/provision.py index 837189204e..2c2525c40a 100644 --- a/dev/provision.py +++ b/dev/provision.py @@ -279,7 +279,7 @@ spark.sql( f""" - CREATE TABLE {catalog_name}.default.test_table_version ( + CREATE TABLE OR REPLACE {catalog_name}.default.test_table_version ( dt date, number integer, letter string From 27438940a6efe99a5a3bcf37866605a06d36ad2e Mon Sep 17 00:00:00 2001 From: Fokko Date: Mon, 23 Jun 2025 22:31:40 +0200 Subject: [PATCH 4/4] Revert or replace --- dev/provision.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/provision.py b/dev/provision.py index 2c2525c40a..837189204e 100644 --- a/dev/provision.py +++ b/dev/provision.py @@ -279,7 +279,7 @@ spark.sql( f""" - CREATE TABLE OR REPLACE {catalog_name}.default.test_table_version ( + CREATE TABLE {catalog_name}.default.test_table_version ( dt date, number integer, letter string