From 2c968412c9fa9de4f471b42ab178fd94330f7e95 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Fri, 4 Jul 2025 13:31:23 +0200 Subject: [PATCH] Fix the CI --- mkdocs/docs/expression-dsl.md | 2 +- mkdocs/docs/row-filter-syntax.md | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/mkdocs/docs/expression-dsl.md b/mkdocs/docs/expression-dsl.md index e8d551d0e6..7dd8b5137b 100644 --- a/mkdocs/docs/expression-dsl.md +++ b/mkdocs/docs/expression-dsl.md @@ -256,4 +256,4 @@ complex_filter = And( EqualTo("type", "enterprise") ) ) -``` \ No newline at end of file +``` diff --git a/mkdocs/docs/row-filter-syntax.md b/mkdocs/docs/row-filter-syntax.md index 45ce195e53..2191b9fd4a 100644 --- a/mkdocs/docs/row-filter-syntax.md +++ b/mkdocs/docs/row-filter-syntax.md @@ -17,11 +17,11 @@ # Row Filter Syntax -In addtion to the primary [Expression DSL](expression-dsl.md), PyIceberg provides a string-based statement interface for filtering rows in Iceberg tables. This guide explains the syntax and provides examples for supported operations. +In addition to the primary [Expression DSL](expression-dsl.md), PyIceberg provides a string-based statement interface for filtering rows in Iceberg tables. This guide explains the syntax and provides examples for supported operations. The row filter syntax is designed to be similar to SQL WHERE clauses. Here are the basic components: -### Column References +## Column References Columns can be referenced using either unquoted or quoted identifiers: @@ -30,7 +30,7 @@ column_name "column.name" ``` -### Literals +## Literals The following literal types are supported: @@ -137,6 +137,7 @@ price IS NOT NULL AND price > 100 AND quantity > 0 ## Common Pitfalls 1. **String Quoting**: Always use single quotes for string literals. Double quotes are reserved for column identifiers. + ```sql -- Correct name = 'John' @@ -146,6 +147,7 @@ price IS NOT NULL AND price > 100 AND quantity > 0 ``` 2. **Wildcard Usage**: The `%` wildcard in LIKE patterns can only appear at the end. + ```sql -- Correct name LIKE 'John%' @@ -155,6 +157,7 @@ price IS NOT NULL AND price > 100 AND quantity > 0 ``` 3. **Case Sensitivity**: Boolean literals (`true`/`false`) are case insensitive, but string comparisons are case sensitive. + ```sql -- All valid is_active = true @@ -169,4 +172,4 @@ price IS NOT NULL AND price > 100 AND quantity > 0 1. For complex use cases, use the primary [Expression DSL](expression-dsl.md) 2. When using multiple conditions, consider the order of operations (NOT > AND > OR) -3. For string comparisons, be consistent with case usage \ No newline at end of file +3. For string comparisons, be consistent with case usage