From f5efabdcc0ecfe7e6b8626cab3e3eadc0901dd23 Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Sat, 19 Jul 2025 10:02:42 -0700 Subject: [PATCH] revert avro timestamp-millis mapping --- pyiceberg/utils/schema_conversion.py | 1 - tests/utils/test_schema_conversion.py | 6 ------ 2 files changed, 7 deletions(-) diff --git a/pyiceberg/utils/schema_conversion.py b/pyiceberg/utils/schema_conversion.py index c73b3ada7d..232b8f0094 100644 --- a/pyiceberg/utils/schema_conversion.py +++ b/pyiceberg/utils/schema_conversion.py @@ -69,7 +69,6 @@ LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = { ("date", "int"): DateType(), ("time-micros", "long"): TimeType(), - ("timestamp-millis", "int"): TimestampType(), ("timestamp-micros", "long"): TimestampType(), ("uuid", "fixed"): UUIDType(), ("uuid", "string"): UUIDType(), diff --git a/tests/utils/test_schema_conversion.py b/tests/utils/test_schema_conversion.py index a5c45447ff..eb44dcdff3 100644 --- a/tests/utils/test_schema_conversion.py +++ b/tests/utils/test_schema_conversion.py @@ -341,12 +341,6 @@ def test_convert_uuid_fixed_type() -> None: assert actual == UUIDType() -def test_convert_timestamp_millis_type() -> None: - avro_logical_type = {"type": "int", "logicalType": "timestamp-millis"} - actual = AvroSchemaConversion()._convert_logical_type(avro_logical_type) - assert actual == TimestampType() - - def test_convert_timestamp_micros_type() -> None: avro_logical_type = {"type": "int", "logicalType": "timestamp-micros"} actual = AvroSchemaConversion()._convert_logical_type(avro_logical_type)