From 025b2b6ef44b16f3c6b1eb36e27fff729e62cfa9 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Fri, 17 Oct 2025 19:51:33 +0200 Subject: [PATCH] Fix expression tests `test_not_equal_to_invert` should test unbound References, Bound one are tested here: https://github.com/apache/iceberg-python/blob/d99936a6aa1758577c27532eb4f91bd15053ce92/tests/expressions/test_expressions.py#L363-L373 --- tests/expressions/test_expressions.py | 30 ++++++--------------------- 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/tests/expressions/test_expressions.py b/tests/expressions/test_expressions.py index 5a0c8c9241..115cc4025f 100644 --- a/tests/expressions/test_expressions.py +++ b/tests/expressions/test_expressions.py @@ -427,51 +427,33 @@ def test_bound_less_than_or_equal_invert(table_schema_simple: Schema) -> None: def test_not_equal_to_invert() -> None: bound = NotEqualTo( - term=BoundReference( # type: ignore - field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False), - accessor=Accessor(position=0, inner=None), - ), + term=Reference("foo"), literal="hello", ) assert ~bound == EqualTo( - term=BoundReference( # type: ignore - field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False), - accessor=Accessor(position=0, inner=None), - ), + term=Reference("foo"), literal="hello", ) def test_greater_than_or_equal_invert() -> None: bound = GreaterThanOrEqual( - term=BoundReference( # type: ignore - field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False), - accessor=Accessor(position=0, inner=None), - ), + term=Reference("foo"), literal="hello", ) assert ~bound == LessThan( - term=BoundReference( # type: ignore - field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False), - accessor=Accessor(position=0, inner=None), - ), + term=Reference("foo"), literal="hello", ) def test_less_than_or_equal_invert() -> None: bound = LessThanOrEqual( - term=BoundReference( # type: ignore - field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False), - accessor=Accessor(position=0, inner=None), - ), + term=Reference("foo"), literal="hello", ) assert ~bound == GreaterThan( - term=BoundReference( # type: ignore - field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False), - accessor=Accessor(position=0, inner=None), - ), + term=Reference("foo"), literal="hello", )