Skip to content

Commit b8fb58e

Browse files
wgtmacdongjoon-hyun
authored andcommitted
ORC-1669: [C++] Deprecate HDFS support
### What changes were proposed in this pull request? Mark readHdfsFile as deprecated. ### Why are the changes needed? Reading ORC on HDFS was introduced in #134 without any test. It has not been updated for 7 years and updating libhdfspp will result in extra dependency like boost library. Staying at an old version of libhdfspp will also prohibit us from updating other libraries like protobuf. ### How was this patch tested? It does not need test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1885 from wgtmac/ORC-1669. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit cea0629) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 parent f2d2a11 commit b8fb58e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ option (ANALYZE_JAVA
4242

4343
option (BUILD_LIBHDFSPP
4444
"Include LIBHDFSPP library in the build process"
45-
ON)
45+
OFF)
4646

4747
option(BUILD_CPP_TESTS
4848
"Build the googletest unit tests"

c++/include/orc/OrcFile.hh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ namespace orc {
127127
* @param path the uri of the file in HDFS
128128
* @param metrics the metrics of the reader
129129
*/
130-
std::unique_ptr<InputStream> readHdfsFile(const std::string& path,
131-
ReaderMetrics* metrics = nullptr);
130+
[[deprecated("readHdfsFile is deprecated in 2.0.1")]] std::unique_ptr<InputStream> readHdfsFile(
131+
const std::string& path, ReaderMetrics* metrics = nullptr);
132132

133133
/**
134134
* Create a reader to read the ORC file.

0 commit comments

Comments
 (0)