Skip to content

Commit f56c3f0

Browse files
committed
test functionality
1 parent f7bbde4 commit f56c3f0

File tree

3 files changed

+9
-75
lines changed

3 files changed

+9
-75
lines changed

.github/cpp-lint.yml

Lines changed: 0 additions & 68 deletions
This file was deleted.

.github/workflows/build_and_test.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ jobs:
176176
./mvnw javadoc:javadoc
177177
178178
cpp-linter:
179-
runs-on: ubuntu-latest
179+
runs-on: ubuntu-24.04
180180
steps:
181181
- uses: actions/checkout@v4
182182
- uses: cpp-linter/cpp-linter-action@v2.13.3
@@ -188,17 +188,16 @@ jobs:
188188
style: file
189189
tidy-checks: file
190190
files-changed-only: true
191-
lines-changed-only: false
191+
lines-changed-only: true
192192
thread-comments: true
193-
ignore: 'build|thirdparty'
193+
ignore: 'build|cmake_modules|conan|dev|docker|examples|java|site'
194194
database: build/compile_commands.json
195-
extra-args: -Wno-unused-parameter
195+
# extra-args: -Wno-unused-parameter
196196
- name: Fail fast?!
197197
if: steps.linter.outputs.checks-failed != 0
198198
run: |
199199
echo "some linter checks failed. ${{ steps.linter.outputs.checks-failed }}"
200-
# for actual deployment
201-
# run: exit 1
200+
exit 1
202201
203202
license-check:
204203
name: "License Check"

c++/include/orc/MemoryPool.hh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,15 @@ namespace orc {
8181
void reserve(uint64_t size);
8282
void resize(uint64_t size);
8383
void zeroOut();
84+
85+
private:
86+
int WRONG_NAME;
8487
};
8588

8689
// Specializations for char
8790

8891
template <>
89-
DataBuffer<char>::~DataBuffer();
92+
DataBuffer<char>::~DataBuffer( );
9093

9194
template <>
9295
void DataBuffer<char>::resize(uint64_t newSize);

0 commit comments

Comments
 (0)