Skip to content

Commit 9728319

Browse files
author
yuzelin
committed
fix
1 parent b3a19f3 commit 9728319

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

paimon_python_api/read_builder.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#################################################################################
1818

1919
from abc import ABC, abstractmethod
20-
from paimon_python_api import TableRead, TableScan, Predicate
20+
from paimon_python_api import TableRead, TableScan, Predicate, PredicateBuilder
2121
from typing import List
2222

2323

@@ -46,3 +46,7 @@ def new_scan(self) -> TableScan:
4646
@abstractmethod
4747
def new_read(self) -> TableRead:
4848
"""Create a TableRead to read splits."""
49+
50+
@abstractmethod
51+
def new_predicate_builder(self) -> PredicateBuilder:
52+
"""Create a builder for Predicate."""

paimon_python_java/pypaimon.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ def new_read(self) -> 'TableRead':
106106
j_table_read = self._j_read_builder.newRead().executeFilter()
107107
return TableRead(j_table_read, self._j_row_type, self._catalog_options, self._arrow_schema)
108108

109-
# TODO: handle projection
110-
# temporarily put here
111109
def new_predicate_builder(self) -> 'PredicateBuilder':
112110
return PredicateBuilder(self._j_row_type)
113111

0 commit comments

Comments
 (0)