Skip to content

Comments

forbid windows sync directory#10057

Merged
RongtongJin merged 1 commit intoapache:developfrom
gaoyf:20250130-fix-windows-sfync-error
Feb 2, 2026
Merged

forbid windows sync directory#10057
RongtongJin merged 1 commit intoapache:developfrom
gaoyf:20250130-fix-windows-sfync-error

Conversation

@gaoyf
Copy link
Contributor

@gaoyf gaoyf commented Jan 30, 2026

Which Issue(s) This PR Fixes

Fixes #9899

Brief Description

Windows does not support fsync diretory.

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.88%. Comparing base (3a184c3) to head (dc678fc).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...c/main/java/org/apache/rocketmq/common/MixAll.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10057      +/-   ##
=============================================
- Coverage      48.96%   48.88%   -0.08%     
+ Complexity     13359    13338      -21     
=============================================
  Files           1373     1373              
  Lines          99743    99745       +2     
  Branches       12888    12889       +1     
=============================================
- Hits           48837    48760      -77     
- Misses         44996    45060      +64     
- Partials        5910     5925      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin merged commit 9388842 into apache:develop Feb 2, 2026
15 of 17 checks passed
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rocketmq5.3.4 Window启动broker日志有报错

4 participants