Skip to content

Commit df6a90a

Browse files
vdusekclaude
andcommitted
test: remove underscore prefix from shared test helper functions
These functions are imported across modules, so they are part of the test package's public API and shouldn't use the private convention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8dd26ac commit df6a90a

File tree

7 files changed

+30
-30
lines changed

7 files changed

+30
-30
lines changed

tests/e2e/test_crawlee_crawlers/conftest.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
_ACTOR_SOURCE_DIR = Path(__file__).parent / 'actor_source'
1616

1717

18-
def _read_actor_source(filename: str) -> str:
18+
def read_actor_source(filename: str) -> str:
1919
return (_ACTOR_SOURCE_DIR / filename).read_text()
2020

2121

22-
def _get_playwright_dockerfile() -> str:
23-
return _read_actor_source('Dockerfile.playwright').replace(
22+
def get_playwright_dockerfile() -> str:
23+
return read_actor_source('Dockerfile.playwright').replace(
2424
'PYTHON_VERSION_PLACEHOLDER',
2525
_PYTHON_VERSION,
2626
)
@@ -33,7 +33,7 @@ def _get_playwright_dockerfile() -> str:
3333
}
3434

3535

36-
async def _verify_crawler_results(
36+
async def verify_crawler_results(
3737
actor: ActorClientAsync,
3838
run_result: ActorRun,
3939
expected_crawler_type: str,

tests/e2e/test_crawlee_crawlers/test_adaptive_playwright_crawler.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from .conftest import _get_playwright_dockerfile, _read_actor_source, _verify_crawler_results
5+
from .conftest import get_playwright_dockerfile, read_actor_source, verify_crawler_results
66

77
if TYPE_CHECKING:
88
from ..conftest import MakeActorFunction, RunActorFunction
@@ -12,12 +12,12 @@ async def test_adaptive_playwright_crawler(make_actor: MakeActorFunction, run_ac
1212
actor = await make_actor(
1313
label='crawl-adaptive',
1414
source_files={
15-
'server.py': _read_actor_source('server.py'),
16-
'src/main.py': _read_actor_source('main_adaptive_playwright_crawler.py'),
17-
'Dockerfile': _get_playwright_dockerfile(),
15+
'server.py': read_actor_source('server.py'),
16+
'src/main.py': read_actor_source('main_adaptive_playwright_crawler.py'),
17+
'Dockerfile': get_playwright_dockerfile(),
1818
},
1919
additional_requirements=['crawlee[all]>=1.0.0,<2.0.0'],
2020
memory_mbytes=1024,
2121
)
2222
run_result = await run_actor(actor)
23-
await _verify_crawler_results(actor, run_result, 'AdaptivePlaywrightCrawler')
23+
await verify_crawler_results(actor, run_result, 'AdaptivePlaywrightCrawler')

tests/e2e/test_crawlee_crawlers/test_basic_crawler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from .conftest import _read_actor_source, _verify_crawler_results
5+
from .conftest import read_actor_source, verify_crawler_results
66

77
if TYPE_CHECKING:
88
from ..conftest import MakeActorFunction, RunActorFunction
@@ -12,9 +12,9 @@ async def test_basic_crawler(make_actor: MakeActorFunction, run_actor: RunActorF
1212
actor = await make_actor(
1313
label='crawl-basic',
1414
source_files={
15-
'server.py': _read_actor_source('server.py'),
16-
'src/main.py': _read_actor_source('main_basic_crawler.py'),
15+
'server.py': read_actor_source('server.py'),
16+
'src/main.py': read_actor_source('main_basic_crawler.py'),
1717
},
1818
)
1919
run_result = await run_actor(actor)
20-
await _verify_crawler_results(actor, run_result, 'BasicCrawler')
20+
await verify_crawler_results(actor, run_result, 'BasicCrawler')

tests/e2e/test_crawlee_crawlers/test_beautifulsoup_crawler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from .conftest import _read_actor_source, _verify_crawler_results
5+
from .conftest import read_actor_source, verify_crawler_results
66

77
if TYPE_CHECKING:
88
from ..conftest import MakeActorFunction, RunActorFunction
@@ -12,10 +12,10 @@ async def test_beautifulsoup_crawler(make_actor: MakeActorFunction, run_actor: R
1212
actor = await make_actor(
1313
label='crawl-bsoup',
1414
source_files={
15-
'server.py': _read_actor_source('server.py'),
16-
'src/main.py': _read_actor_source('main_beautifulsoup_crawler.py'),
15+
'server.py': read_actor_source('server.py'),
16+
'src/main.py': read_actor_source('main_beautifulsoup_crawler.py'),
1717
},
1818
additional_requirements=['crawlee[beautifulsoup]>=1.0.0,<2.0.0'],
1919
)
2020
run_result = await run_actor(actor)
21-
await _verify_crawler_results(actor, run_result, 'BeautifulSoupCrawler')
21+
await verify_crawler_results(actor, run_result, 'BeautifulSoupCrawler')

tests/e2e/test_crawlee_crawlers/test_http_crawler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from .conftest import _read_actor_source, _verify_crawler_results
5+
from .conftest import read_actor_source, verify_crawler_results
66

77
if TYPE_CHECKING:
88
from ..conftest import MakeActorFunction, RunActorFunction
@@ -12,9 +12,9 @@ async def test_http_crawler(make_actor: MakeActorFunction, run_actor: RunActorFu
1212
actor = await make_actor(
1313
label='crawl-http',
1414
source_files={
15-
'server.py': _read_actor_source('server.py'),
16-
'src/main.py': _read_actor_source('main_http_crawler.py'),
15+
'server.py': read_actor_source('server.py'),
16+
'src/main.py': read_actor_source('main_http_crawler.py'),
1717
},
1818
)
1919
run_result = await run_actor(actor)
20-
await _verify_crawler_results(actor, run_result, 'HttpCrawler')
20+
await verify_crawler_results(actor, run_result, 'HttpCrawler')

tests/e2e/test_crawlee_crawlers/test_parsel_crawler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from .conftest import _read_actor_source, _verify_crawler_results
5+
from .conftest import read_actor_source, verify_crawler_results
66

77
if TYPE_CHECKING:
88
from ..conftest import MakeActorFunction, RunActorFunction
@@ -12,9 +12,9 @@ async def test_parsel_crawler(make_actor: MakeActorFunction, run_actor: RunActor
1212
actor = await make_actor(
1313
label='crawl-parsel',
1414
source_files={
15-
'server.py': _read_actor_source('server.py'),
16-
'src/main.py': _read_actor_source('main_parsel_crawler.py'),
15+
'server.py': read_actor_source('server.py'),
16+
'src/main.py': read_actor_source('main_parsel_crawler.py'),
1717
},
1818
)
1919
run_result = await run_actor(actor)
20-
await _verify_crawler_results(actor, run_result, 'ParselCrawler')
20+
await verify_crawler_results(actor, run_result, 'ParselCrawler')

tests/e2e/test_crawlee_crawlers/test_playwright_crawler.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from .conftest import _get_playwright_dockerfile, _read_actor_source, _verify_crawler_results
5+
from .conftest import get_playwright_dockerfile, read_actor_source, verify_crawler_results
66

77
if TYPE_CHECKING:
88
from ..conftest import MakeActorFunction, RunActorFunction
@@ -12,12 +12,12 @@ async def test_playwright_crawler(make_actor: MakeActorFunction, run_actor: RunA
1212
actor = await make_actor(
1313
label='crawl-playwright',
1414
source_files={
15-
'server.py': _read_actor_source('server.py'),
16-
'src/main.py': _read_actor_source('main_playwright_crawler.py'),
17-
'Dockerfile': _get_playwright_dockerfile(),
15+
'server.py': read_actor_source('server.py'),
16+
'src/main.py': read_actor_source('main_playwright_crawler.py'),
17+
'Dockerfile': get_playwright_dockerfile(),
1818
},
1919
additional_requirements=['crawlee[playwright]>=1.0.0,<2.0.0'],
2020
memory_mbytes=1024,
2121
)
2222
run_result = await run_actor(actor)
23-
await _verify_crawler_results(actor, run_result, 'PlaywrightCrawler')
23+
await verify_crawler_results(actor, run_result, 'PlaywrightCrawler')

0 commit comments

Comments
 (0)