Remove {PrivateInformationRetrieval,PrivateNearestNeighborSearch}Protobuf (#234)

Author: fboemer

.spi.yml

@@ -2,6 +2,7 @@ version: 1
 builder:
   configs:
     - documentation_targets:
+        - ApplicationProtobuf
         - HomomorphicEncryption
         - HomomorphicEncryptionProtobuf
         - PIRGenerateDatabase
@@ -10,7 +11,5 @@ builder:
         - PNNSGenerateDatabase
         - PNNSProcessDatabase
         - PrivateInformationRetrieval
-        - PrivateInformationRetrievalProtobuf
         - PrivateNearestNeighborSearch
-        - PrivateNearestNeighborSearchProtobuf
       swift_version: 6.0

Package.resolved

@@ -46,15 +46,9 @@ let package = Package(
         .library(
             name: "PrivateInformationRetrieval",
             targets: ["PrivateInformationRetrieval"]),
-        .library(
-            name: "PrivateInformationRetrievalProtobuf",
-            targets: ["PrivateInformationRetrievalProtobuf"]),
         .library(
             name: "PrivateNearestNeighborSearch",
             targets: ["PrivateNearestNeighborSearch"]),
-        .library(
-            name: "PrivateNearestNeighborSearchProtobuf",
-            targets: ["PrivateNearestNeighborSearchProtobuf"]),
         .library(name: "ApplicationProtobuf", targets: ["ApplicationProtobuf"]),
         .library(name: "_TestUtilities", targets: ["_TestUtilities"]),
         .executable(name: "PIRGenerateDatabase", targets: ["PIRGenerateDatabase"]),
@@ -109,14 +103,6 @@ let package = Package(
             dependencies: ["HomomorphicEncryption",
                            .product(name: "Numerics", package: "swift-numerics")],
             swiftSettings: librarySettings),
-        .target(
-            name: "PrivateInformationRetrievalProtobuf",
-            dependencies: ["PrivateInformationRetrieval",
-                           "HomomorphicEncryption",
-                           "HomomorphicEncryptionProtobuf",
-                           .product(name: "SwiftProtobuf", package: "swift-protobuf")],
-            exclude: ["generated/README.md", "protobuf_module_mappings.txtpb"],
-            swiftSettings: librarySettings),
         .target(
             name: "PrivateNearestNeighborSearch",
             dependencies: [
@@ -125,14 +111,6 @@ let package = Package(
                 "_HomomorphicEncryptionExtras",
             ],
             swiftSettings: librarySettings),
-        .target(
-            name: "PrivateNearestNeighborSearchProtobuf",
-            dependencies: ["PrivateNearestNeighborSearch",
-                           "HomomorphicEncryption",
-                           "HomomorphicEncryptionProtobuf",
-                           .product(name: "SwiftProtobuf", package: "swift-protobuf")],
-            exclude: ["generated/README.md", "protobuf_module_mappings.txtpb"],
-            swiftSettings: librarySettings),
         .target(
             name: "ApplicationProtobuf",
             dependencies: ["HomomorphicEncryptionProtobuf",
@@ -156,15 +134,15 @@ let package = Package(
             dependencies: [
                 .product(name: "ArgumentParser", package: "swift-argument-parser"),
                 "HomomorphicEncryption",
-                "PrivateInformationRetrievalProtobuf",
+                "ApplicationProtobuf",
             ],
             swiftSettings: executableSettings),
         .executableTarget(
             name: "PIRProcessDatabase",
             dependencies: [
                 .product(name: "ArgumentParser", package: "swift-argument-parser"),
                 "HomomorphicEncryptionProtobuf",
-                "PrivateInformationRetrievalProtobuf",
+                "ApplicationProtobuf",
                 "HomomorphicEncryption",
                 .product(name: "Logging", package: "swift-log"),
             ],
@@ -174,23 +152,23 @@ let package = Package(
             dependencies: [
                 .product(name: "ArgumentParser", package: "swift-argument-parser"),
                 "HomomorphicEncryption",
-                "PrivateInformationRetrievalProtobuf",
+                "ApplicationProtobuf",
             ],
             swiftSettings: executableSettings),
         .executableTarget(
             name: "PNNSGenerateDatabase",
             dependencies: [
                 .product(name: "ArgumentParser", package: "swift-argument-parser"),
                 "HomomorphicEncryption",
-                "PrivateNearestNeighborSearchProtobuf",
+                "ApplicationProtobuf",
             ],
             swiftSettings: executableSettings),
         .executableTarget(
             name: "PNNSProcessDatabase",
             dependencies: [
                 .product(name: "ArgumentParser", package: "swift-argument-parser"),
                 "HomomorphicEncryptionProtobuf",
-                "PrivateNearestNeighborSearchProtobuf",
+                "ApplicationProtobuf",
                 "HomomorphicEncryption",
                 .product(name: "Logging", package: "swift-log"),
             ],
@@ -229,24 +207,11 @@ let package = Package(
                 "PrivateInformationRetrieval", "_TestUtilities",
                 .product(name: "Numerics", package: "swift-numerics"),
             ], swiftSettings: executableSettings),
-        .testTarget(
-            name: "PrivateInformationRetrievalProtobufTests",
-            dependencies: [
-                "PrivateInformationRetrieval",
-                "PrivateInformationRetrievalProtobuf",
-                "_TestUtilities",
-            ], swiftSettings: executableSettings),
         .testTarget(
             name: "PrivateNearestNeighborSearchTests",
             dependencies: [
                 "PrivateNearestNeighborSearch", "HomomorphicEncryption", "_TestUtilities",
             ], swiftSettings: executableSettings),
-        .testTarget(
-            name: "PrivateNearestNeighborSearchProtobufTests",
-            dependencies: [
-                "PrivateNearestNeighborSearch",
-                "PrivateNearestNeighborSearchProtobuf",
-            ], swiftSettings: executableSettings),
         .testTarget(
             name: "ApplicationProtobufTests",
             dependencies: [
@@ -282,9 +247,8 @@ if enableBenchmarking {
                 "HomomorphicEncryption",
                 "HomomorphicEncryptionProtobuf",
                 "PrivateInformationRetrieval",
-                "PrivateInformationRetrievalProtobuf",
                 "PrivateNearestNeighborSearch",
-                "PrivateNearestNeighborSearchProtobuf",
+                "ApplicationProtobuf",
             ],
             swiftSettings: benchmarkSettings),
         .executableTarget(

Package.swift

@@ -11,9 +11,8 @@ Swift Homomorphic Encryption is a collection of libraries and executables.
 For more information, refer to documentation for the libraries:
 * [HomomorphicEncryptionProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/homomorphicencryptionprotobuf)
 * [HomomorphicEncryption](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/homomorphicencryption)
-* [PrivateInformationRetrievalProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privateinformationretrievalprotobuf)
+* [ApplicationProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/applicationprotobuf)
 * [PrivateInformationRetrieval](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privateinformationretrieval)
-* [PrivateNearestNeighborSearchProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privatenearestneighborsearchprotobuf)
 * [PrivateNearestNeighborSearch](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privatenearestneighborsearch)
 
 and executables:

README.md

@@ -7,9 +7,8 @@ Swift Homomorphic Encryption is a collection of libraries and executables implem
 For more information, refer to documentation for the libraries:
 * [HomomorphicEncryptionProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/homomorphicencryptionprotobuf)
 * [HomomorphicEncryption](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/homomorphicencryption)
-* [PrivateInformationRetrievalProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privateinformationretrievalprotobuf)
+* [ApplicationProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/applicationprotobuf)
 * [PrivateInformationRetrieval](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privateinformationretrieval)
-* [PrivateNearestNeighborSearchProtobuf](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privatenearestneighborsearchprotobuf)
 * [PrivateNearestNeighborSearch](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privatenearestneighborsearch)
 
 and executables:

Sources/HomomorphicEncryption/HomomorphicEncryption.docc/HomomorphicEncryption.md

@@ -34,7 +34,7 @@ PIRGenerateDatabase \
 
 This will generate a database of 100 rows, with keywords 0 to 99, and each value repeating the keyword for 10 to 20 bytes.
 
-The database is a serialized [Apple_SwiftHomomorphicEncryption_Pir_V1_KeywordDatabase](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privateinformationretrievalprotobuf/apple_swifthomomorphicencryption_pir_v1_keyworddatabase).
+The database is a serialized [Apple_SwiftHomomorphicEncryption_Pir_V1_KeywordDatabase](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/applicationprotobuf/apple_swifthomomorphicencryption_pir_v1_keyworddatabase).
 For readability, the `.txtpb` extension ensures the output database will be saved in protocol buffer text format.
 
 > Note: For a more compact format, use the `.binpb` extension to save the database in protocol buffer binary format.

Sources/PIRGenerateDatabase/PIRGenerateDatabase.docc/PIRGenerateDatabase.md

@@ -12,11 +12,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import ApplicationProtobuf
 import ArgumentParser
 import Foundation
 import HomomorphicEncryption
 import PrivateInformationRetrieval
-import PrivateInformationRetrievalProtobuf
 
 enum ValueTypeArguments: String, CaseIterable, ExpressibleByArgument {
     case random

Sources/PIRGenerateDatabase/main.swift

@@ -36,7 +36,7 @@ There are four required parameters:
 1. `rlweParameters` is one of the [PredefinedRlweParameters](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/homomorphicencryption/predefinedrlweparameters),
 e.g., `n_4096_logq_27_28_28_logt_5`.
 2. `inputDatabase` is the path to the unprocessed input database. It must be a
-serialized [Apple_SwiftHomomorphicEncryption_Pir_V1_KeywordDatabase](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/privateinformationretrievalprotobuf/apple_swifthomomorphicencryption_pir_v1_keyworddatabase).
+serialized [Apple_SwiftHomomorphicEncryption_Pir_V1_KeywordDatabase](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/applicationprotobuf/apple_swifthomomorphicencryption_pir_v1_keyworddatabase).
 
 > Note: The [PIRGenerateDatabase](https://swiftpackageindex.com/apple/swift-homomorphic-encryption/main/documentation/pirgeneratedatabase) binary can be used to generate a sample database.
 

Sources/PIRProcessDatabase/PIRProcessDatabase.docc/PIRProcessDatabase.md

@@ -12,14 +12,14 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import ApplicationProtobuf
 import ArgumentParser
 import Crypto
 import Foundation
 import HomomorphicEncryption
 import HomomorphicEncryptionProtobuf
 import Logging
 import PrivateInformationRetrieval
-import PrivateInformationRetrievalProtobuf
 
 /// The different table sizes that can be used for the PIR database.
 enum TableSizeOption: Codable, Equatable, Hashable {
@@ -561,8 +561,7 @@ extension ProcessKeywordDatabase.ShardValidationResult {
         descriptionDict["evaluation key size"] = try sizeString(
             byteCount: evaluationKey.size(),
             count: evaluationKey.config.keyCount,
-            label: "keys"
-        )
+            label: "keys")
         descriptionDict["response size"] = try sizeString(byteCount: response.size(),
                                                           count: response.ciphertexts.flatMap(\.self).count,
                                                           label: "ciphertexts")

Sources/PIRProcessDatabase/main.swift

@@ -12,10 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import ApplicationProtobuf
 import ArgumentParser
 import HomomorphicEncryption
 import PrivateInformationRetrieval
-import PrivateInformationRetrievalProtobuf
 
 extension KeywordDatabaseShard {
     func save(to path: String) throws {