Merge pull request #22 from DReigada/improve-report-error-message

Improve error message when parsing failed (FT-4854)

Author: rtfpessoa

src/main/scala/com/codacy/parsers/CoverageParser.scala

@@ -19,6 +19,7 @@ trait CoverageParser {
 
   def generateReport(): CoverageReport
 
+  def name: String
 }
 
 trait XMLCoverageParser extends CoverageParser {
@@ -48,7 +49,9 @@ object CoverageParserFactory {
     } else {
       parserFactory.fold[Either[String, A]] {
         val parsers = allParsers(language, rootProject, reportFile)
-        withReport(parsers)(s"could not parse report, unrecognized report format")(block)
+        val parsersNames = parsers.map(_.name).mkString(", ")
+
+        withReport(parsers)(s"could not parse report, unrecognized report format (tried: $parsersNames)")(block)
       } { parserFactory =>
         val parser = parserFactory(language, rootProject, reportFile)
         withReport(Seq(parser))("could not parse report with the provided parser")(block)

src/main/scala/com/codacy/parsers/implementation/CoberturaParser.scala

@@ -18,6 +18,8 @@ object CoberturaParser extends CoverageParserFactory {
 
 class CoberturaParser(val language: Language.Value, val rootProject: File, val coverageReport: File) extends XMLCoverageParser {
 
+  override val name = "Cobertura"
+
   val rootProjectDir = sanitiseFilename(rootProject.getAbsolutePath + File.separator)
 
   lazy val allFiles = recursiveListFiles(rootProject) { file =>

src/main/scala/com/codacy/parsers/implementation/JacocoParser.scala

@@ -16,6 +16,8 @@ object JacocoParser extends CoverageParserFactory {
 
 class JacocoParser(val language: Language.Value, val rootProject: File, val coverageReport: File) extends XMLCoverageParser {
 
+  override val name = "Jacoco"
+
   val rootProjectDir = rootProject.getAbsolutePath + File.separator
 
   override def isValidReport: Boolean = {

src/test/scala/com/codacy/parsers/CoverageParserFactoryTest.scala

@@ -30,7 +30,7 @@ class CoverageParserFactoryTest extends WordSpec with BeforeAndAfterAll with Mat
 
     "fail to get invalid report" in {
       runForFile("invalid_report.xml", None) shouldEqual
-        Left("could not parse report, unrecognized report format")
+        Left("could not parse report, unrecognized report format (tried: Cobertura, Jacoco)")
     }
 
     "fail to get report with wrong parser" in {