`drawPixel` doesn't set the refresh flag

[PickyBiker]

The drawPixel function fills the screen buffer with the appropriate color, but it fails to set the refresh flag, so the buffer never goes to the screen.

I added _refresh_thd->flags_set(0x1); to the end of the function and that fixed it.

Alternatively, endWrite could be added to the end of the function. This would accomplish the same thing, but would be a bit slower.

[PickyBiker]

Per,

It seems drawPixel not updating the screen might be intentional. If someone wants to draw something with a lot of pixels, they can do so with or without sending the buffer to the screen. Drawing without sending the buffer after drawing each pixel doesn't really save time, but it does make the drawing invisible until endWrite is executed or when one of the other drawing commands like line, rect, or circle, all of which update the screen. This is inconsistent.

If there is a good argument for this inconsistent drawPixel and fillScreen behavior, it might be best to allow an option the developer can use to determine whether or not to update the screen.

I would suggest something like an option arg at the end set to a default of true that would cause a screen update. No last arg would also be true, and false would not update the screen.

[per1234]

It seems drawPixel not updating the screen might be intentional.

This was also my impression. But I'm not involved in the development of the library so I didn't make a ruling on the issue.

If there is a good argument for this inconsistent drawPixel and fillScreen behavior, it might be best to allow an option the developer can use to determine whether or not to update the screen.

Please note that the endWrite call was added to fillScreen in 58e5a92. This is why I removed that part of your report. I guess you are using the release version of the library. There hasn't been a release since 58e5a92, so that change is only present when using the development version of the library.

it might be best to allow an option the developer can use to determine whether or not to update the screen.

This was added in f37a8f2 (also only available when using the development version of the library).

[PickyBiker]

Thanks per. Is there a way for me to get the development version of the library?

…

On Thu, Mar 13, 2025 at 2:54 PM Per Tillisch ***@***.***> wrote: It seems drawPixel not updating the screen might be intentional. This was also my impression. But I'm not involved in the development of the library so I didn't make a ruling on the issue. If there is a good argument for this inconsistent drawPixel and fillScreen behavior, it might be best to allow an option the developer can use to determine whether or not to update the screen. Please note that the endWrite call was added to fillScreen in 58e5a92 <58e5a92>. This is why I removed that part of your report. I guess you are using the release version of the library. There hasn't been a release since 58e5a92 <58e5a92>, so that change is only present when using the development version of the library. it might be best to allow an option the developer can use to determine whether or not to update the screen. This was added in f37a8f2 <f37a8f2> (also only available when using the development version of the library). — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4G3TZPENNAWDMSYW756O32UHO6VAVCNFSM6AAAAABY4OZFXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRSGU2DIMZRHA> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: per1234]*per1234* left a comment (arduino-libraries/Arduino_GigaDisplay_GFX#8) <#8 (comment)> It seems drawPixel not updating the screen might be intentional. This was also my impression. But I'm not involved in the development of the library so I didn't make a ruling on the issue. If there is a good argument for this inconsistent drawPixel and fillScreen behavior, it might be best to allow an option the developer can use to determine whether or not to update the screen. Please note that the endWrite call was added to fillScreen in 58e5a92 <58e5a92>. This is why I removed that part of your report. I guess you are using the release version of the library. There hasn't been a release since 58e5a92 <58e5a92>, so that change is only present when using the development version of the library. it might be best to allow an option the developer can use to determine whether or not to update the screen. This was added in f37a8f2 <f37a8f2> (also only available when using the development version of the library). — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4G3TZPENNAWDMSYW756O32UHO6VAVCNFSM6AAAAABY4OZFXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRSGU2DIMZRHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[per1234]

1. Uninstall the release version of the library from your computer.
2. Navigate to library's GitHub repository homepage in your web browser: https://github.com/arduino-libraries/Arduino_GigaDisplay_GFX
3. Click the "Code ▾" button you see on that page.
4. Select Download ZIP from the menu.
   A download of the ZIP file of the library will start.
5. Select Sketch > Include library > Add .ZIP Library from the Arduino IDE menus.
   The "Select the zip file containing the library you'd like to add" dialog will open.
6. Select the downloaded file from the dialog.
7. Click the "Open" button.
   The dialog will close.

You will now have the development version of the library installed.

[PickyBiker]

Thank you per!