Skip to content

Commit 238cb0f

Browse files
committed
Opta: display model name as object node name and SKU as ModelName.
1 parent 29edc1d commit 238cb0f

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

src/Opta.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Opta::SharedPtr Opta::create(UA_Server * server, OptaVariant::Type const opta_ty
4646
UA_StatusCode rc = UA_STATUSCODE_GOOD;
4747

4848
UA_ObjectAttributes oAttr = UA_ObjectAttributes_default;
49-
oAttr.displayName = UA_LOCALIZEDTEXT("en-US", "Arduino Opta");
49+
oAttr.displayName = UA_LOCALIZEDTEXT("en-US", (char *)OptaVariant::toString(opta_type).c_str());
5050
UA_NodeId node_id;
5151
rc = UA_Server_addObjectNode(server,
5252
UA_NODEID_NULL,
@@ -87,7 +87,7 @@ Opta::SharedPtr Opta::create(UA_Server * server, OptaVariant::Type const opta_ty
8787
}
8888

8989
UA_VariableAttributes modelAttr = UA_VariableAttributes_default;
90-
UA_String modelName = UA_STRING((char *)OptaVariant::toString(opta_type).c_str());
90+
UA_String modelName = UA_STRING((char *)OptaVariant::toSKUString(opta_type).c_str());
9191
UA_Variant_setScalar(&modelAttr.value, &modelName, &UA_TYPES[UA_TYPES_STRING]);
9292
modelAttr.displayName = UA_LOCALIZEDTEXT("en-US", "ModelName");
9393
rc = UA_Server_addVariableNode(server,

src/OptaVariant.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,17 @@ std::string OptaVariant::toString(Type const type)
6262
}
6363
}
6464

65+
std::string OptaVariant::toSKUString(Type const type)
66+
{
67+
switch(type)
68+
{
69+
case OptaVariant::Type::WiFi: return std::string("AFX00002"); break;
70+
case OptaVariant::Type::RS485: return std::string("AFX00001"); break;
71+
case OptaVariant::Type::Lite: return std::string("AFX00003"); break;
72+
default: __builtin_unreachable(); break;
73+
}
74+
}
75+
6576
/**************************************************************************************
6677
* NAMESPACE
6778
**************************************************************************************/

src/OptaVariant.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class OptaVariant
3737
static bool get_opta_variant(Type & type);
3838

3939
static std::string toString(Type const type);
40+
static std::string toSKUString(Type const type);
4041
};
4142

4243
/**************************************************************************************

0 commit comments

Comments
 (0)