Skip to content

Commit d5a2ff4

Browse files
committed
Fix: do not use raw ADC reading but already converted pin voltage.
Also no need to periodically update anymore, as we are doing the update right when reading the OPC UA property.
1 parent 5f461f7 commit d5a2ff4

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

examples/opcua_server/opcua_server.ino

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ void setup()
284284
/* Expose analog inputs as readable OPC UA properties. */
285285
char analog_in_name[32] = {0};
286286
snprintf(analog_in_name, sizeof(analog_in_name), "Analog Input I%d", a + 1);
287-
exp_analog->analog_input_mgr()->add_analog_input(opc_ua_server, analog_in_name, [i, a]() { return reinterpret_cast<AnalogExpansion *>(OptaController.getExpansionPtr(i))->analogRead(a); });
287+
exp_analog->analog_input_mgr()->add_analog_input(opc_ua_server, analog_in_name, [i, a]() { return reinterpret_cast<AnalogExpansion *>(OptaController.getExpansionPtr(i))->pinVoltage(a); });
288288
}
289289
}
290290
}
@@ -398,8 +398,6 @@ void loop()
398398
reinterpret_cast<DigitalMechExpansion *>(OptaController.getExpansionPtr(i))->updateDigitalOutputs();
399399
else if (exp_type == EXPANSION_OPTA_DIGITAL_STS)
400400
reinterpret_cast<DigitalStSolidExpansion *>(OptaController.getExpansionPtr(i))->updateDigitalOutputs();
401-
else if (exp_type == EXPANSION_OPTA_ANALOG)
402-
reinterpret_cast<AnalogExpansion *>(OptaController.getExpansionPtr(i))->updateAnalogInputs();
403401
}
404402

405403
/* Toggle main LED signalling progress. */

0 commit comments

Comments
 (0)