File open with O_WRITE would always append, even when O_APPEND is off

Kees Bakker · sandeepmistry · commit a638e87d24a4 · 2017-10-02T09:42:14.000-04:00
diff --git a/src/SD.cpp b/src/SD.cpp
@@ -470,7 +470,7 @@ File SDClass::open(const char *filepath, uint8_t mode) {
     parentdir.close();
   }
 
-  if (mode & (O_APPEND | O_WRITE)) 
+  if ((mode & (O_APPEND | O_WRITE)) == (O_APPEND | O_WRITE))
     file.seekSet(file.fileSize());
   return File(file, filepath);
 }

Original file line number	Diff line number	Diff line change
`@@ -470,7 +470,7 @@ File SDClass::open(const char *filepath, uint8_t mode) {`
`470`	`470`	`parentdir.close();`
`471`	`471`	`}`
`472`	`472`
`473`		`- if (mode & (O_APPEND \| O_WRITE))`
	`473`	`+ if ((mode & (O_APPEND \| O_WRITE)) == (O_APPEND \| O_WRITE))`
`474`	`474`	`file.seekSet(file.fileSize());`
`475`	`475`	`return File(file, filepath);`
`476`	`476`	`}`