Replace SSHUploader file filter

- The file names in FILES_NOT_TO_COPY are full names and not partial names, so the check should not check if a file name contains such a name, but rather whether a file name fully matches such a name.
- Replaced the FILES_NOT_TO_COPY by a HashSet since this provides O(1) lookups, rather than O(n) lookups where n is the size of the set.

Author: Pieter12345

arduino-core/src/cc/arduino/packages/uploaders/SSHUploader.java

@@ -49,13 +49,17 @@
 import java.io.File;
 import java.io.IOException;
 import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 import static processing.app.I18n.tr;
 
 public class SSHUploader extends Uploader {
 
-  private static final List<String> FILES_NOT_TO_COPY = Arrays.asList(".DS_Store", ".Trash", "Thumbs.db", "__MACOSX");
+  private static final Set<String> FILES_NOT_TO_COPY =
+      Collections.unmodifiableSet(new HashSet<String>(Arrays.asList(".DS_Store", ".Trash", "Thumbs.db", "__MACOSX")));
 
   private final BoardPort port;
 
@@ -223,7 +227,7 @@ private void recursiveSCP(File from, SCP scp) throws IOException {
     }
 
     for (File file : files) {
-      if (!StringUtils.stringContainsOneOf(file.getName(), FILES_NOT_TO_COPY)) {
+      if (!FILES_NOT_TO_COPY.contains(file.getName())) {
         if (file.isDirectory() && file.canExecute()) {
           scp.startFolder(file.getName());
           recursiveSCP(file, scp);