Add support for JVMClassPath entry in Info.plist.

git-svn-id: https://svn.java.net/svn/appbundler~svn@8 07572b26-92e5-4d45-f66a-c18421440a21

Author: gk_brown

appbundler/native/main.m

@@ -32,6 +32,7 @@
 
 #define JVM_RUNTIME_KEY "JVMRuntime"
 #define JVM_MAIN_CLASS_NAME_KEY "JVMMainClassName"
+#define JVM_CLASS_PATH_KEY "JVMClassPath"
 #define JVM_OPTIONS_KEY "JVMOptions"
 #define JVM_ARGUMENTS_KEY "JVMArguments"
 
@@ -119,25 +120,25 @@ int launch(char *commandName) {
     }
 
     // Set the class path
-    NSString *classPathFormat = @"-Djava.class.path=%@/Classes";
-    NSString *javaPath = [mainBundlePath stringByAppendingString:@"/Contents/Java"];
-    NSMutableString *classPath = [[NSString stringWithFormat:classPathFormat, javaPath] mutableCopy];
-
-    NSFileManager *defaultFileManager = [NSFileManager defaultManager];
-    NSArray *javaDirectoryContents = [defaultFileManager contentsOfDirectoryAtPath:javaPath error:nil];
-    if (javaDirectoryContents == nil) {
-        [NSException raise:@JAVA_LAUNCH_ERROR format:@"Could not enumerate Java directory contents."];
+    NSMutableString *classPath = [NSMutableString stringWithString:@"-Djava.class.path="];
+    NSArray *classPathEntries = [infoDictionary objectForKey:@JVM_CLASS_PATH_KEY];
+    if (classPathEntries == nil || [classPathEntries count] == 0) {
+        [NSException raise:@JAVA_LAUNCH_ERROR format:@"%@ is required.", @JVM_CLASS_PATH_KEY];
     }
 
-    for (NSString *file in javaDirectoryContents) {
-        if ([file hasSuffix:@".jar"]) {
-            [classPath appendFormat:@":%@/%@", javaPath, file];
+    for (int i = 0, n = [classPathEntries count]; i < n; i++) {
+        NSString *classPathEntry = [classPathEntries objectAtIndex:i];
+        if (i > 0) {
+            [classPath appendString:@":"];
         }
+
+        [classPath appendFormat:@"%@/%@", mainBundlePath, classPathEntry];
     }
 
+    NSLog(@"classPath = %@", classPath);
+
     // Set the library path
-    NSString *libraryPathFormat = @"-Djava.library.path=%@";
-    NSString *libraryPath = [NSString stringWithFormat:libraryPathFormat, javaPath];
+    NSString *libraryPath = [NSString stringWithFormat:@"-Djava.library.path=%@/Contents/MacOS", mainBundlePath];
 
     // Get the VM options
     NSArray *options = [infoDictionary objectForKey:@JVM_OPTIONS_KEY];

appbundler/src/com/oracle/appbundler/AppBundlerTask.java

@@ -139,7 +139,12 @@ public void addConfiguredClassPath(FileSet classPath) {
         String[] includedFiles = directoryScanner.getIncludedFiles();
 
         for (int i = 0; i < includedFiles.length; i++) {
-            this.classPath.add(new File(parent, includedFiles[i]));
+            File entry = new File(parent, includedFiles[i]);
+            if (entry.isDirectory()) {
+                throw new BuildException("Class path entry cannot be a directory.");
+            }
+
+            this.classPath.add(entry);
         }
     }
 
@@ -259,25 +264,12 @@ public void execute() throws BuildException {
             File javaDirectory = new File(contentsDirectory, "Java");
             javaDirectory.mkdir();
 
-            File classesDirectory = new File(javaDirectory, "Classes");
-            classesDirectory.mkdir();
-
             File plugInsDirectory = new File(contentsDirectory, "PlugIns");
             plugInsDirectory.mkdir();
 
             File resourcesDirectory = new File(contentsDirectory, "Resources");
             resourcesDirectory.mkdir();
 
-            // Generate Info.plist
-            File infoPlistFile = new File(contentsDirectory, "Info.plist");
-            infoPlistFile.createNewFile();
-            writeInfoPlist(infoPlistFile);
-
-            // Generate PkgInfo
-            File pkgInfoFile = new File(contentsDirectory, "PkgInfo");
-            pkgInfoFile.createNewFile();
-            writePkgInfo(pkgInfoFile);
-
             // Copy executable to MacOS folder
             File executableFile = new File(macOSDirectory, EXECUTABLE_NAME);
             copy(getClass().getResource(EXECUTABLE_NAME), executableFile);
@@ -291,20 +283,25 @@ public void execute() throws BuildException {
 
             // Copy class path entries to Java folder
             for (File entry : classPath) {
-                String name = entry.getName();
-
-                if (entry.isDirectory() || name.endsWith(CLASS_EXTENSION)) {
-                    copy(entry, new File(classesDirectory, name));
-                } else {
-                    copy(entry, new File(javaDirectory, name));
-                }
+                // TODO Don't copy if in JRE
+                copy(entry, new File(javaDirectory, entry.getName()));
             }
 
-            // Copy native libraries to Java folder
+            // Copy native libraries to MacOS folder
             for (File nativeLibrary : nativeLibraries) {
-                copy(nativeLibrary, new File(javaDirectory, nativeLibrary.getName()));
+                copy(nativeLibrary, new File(macOSDirectory, nativeLibrary.getName()));
             }
 
+            // Generate Info.plist
+            File infoPlistFile = new File(contentsDirectory, "Info.plist");
+            infoPlistFile.createNewFile();
+            writeInfoPlist(infoPlistFile);
+
+            // Generate PkgInfo
+            File pkgInfoFile = new File(contentsDirectory, "PkgInfo");
+            pkgInfoFile.createNewFile();
+            writePkgInfo(pkgInfoFile);
+
             // Copy icon to Resources folder
             if (icon == null) {
                 copy(getClass().getResource(DEFAULT_ICON_NAME), new File(resourcesDirectory,
@@ -363,6 +360,20 @@ private void writeInfoPlist(File file) throws IOException {
             // Write main class name
             writeProperty(xout, "JVMMainClassName", mainClassName);
 
+            // Write class path
+            writeKey(xout, "JVMClassPath");
+
+            xout.writeStartElement(ARRAY_TAG);
+            xout.writeCharacters("\n");
+
+            for (File entry : classPath) {
+                // TODO Write appropriate path based on location
+                writeString(xout, "Contents/Java/" + entry.getName());
+            }
+
+            xout.writeEndElement();
+            xout.writeCharacters("\n");
+
             // Write options
             writeKey(xout, "JVMOptions");
 

build.xml

@@ -89,19 +89,15 @@ questions.
 
     <!-- Clean target -->
     <target name="clean">
-        <delete dir="${ant.project.name}/${folder.classes}"/>
-        <delete file="${ant.project.name}/${folder.bin}/${ant.project.name}-${version}.jar"/>
+        <delete dir="${ant.project.name}/${folder.bin}"/>
         <delete dir="HelloWorld.app"/>
         <delete dir="SwingSet2.app"/>
         <delete dir="SwingSet2Plugin.app"/>
     </target>
 
     <!-- Package target -->
     <target name="package" depends="compile">
-        <property name="destfile" value="${ant.project.name}/${folder.bin}/${ant.project.name}-${version}.jar"/>
-
-        <delete file="${destfile}"/>
-        <jar destfile="${destfile}" index="true">
+        <jar destfile="${ant.project.name}/${folder.bin}/${ant.project.name}-${version}.jar" index="true">
             <manifest>
                 <attribute name="Implementation-Vendor-Id" value="com.oracle"/>
                 <attribute name="Implementation-Vendor" value="Oracle"/>