enhance tests

Author: mirkoCrobu

pkg/flasherapi/flasherapi_test.go

@@ -12,16 +12,62 @@
 // modify or otherwise use the software for commercial activities involving the
 // Arduino software without disclosing the source code of your own applications.
 // To purchase a commercial license, send an email to license@arduino.cc.
-
 package flasherapi
 
 import (
+	"context"
+	"io"
 	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
+
+	"github.com/arduino/arduino-app-cli/pkg/board/remote"
 )
 
+// implements remote.RemoteConn
+type MockRemoteConn struct {
+	ReadFileFunc func(path string) (io.ReadCloser, error)
+}
+
+func (m *MockRemoteConn) ReadFile(path string) (io.ReadCloser, error) {
+	return m.ReadFileFunc(path)
+}
+
+// Empty definitions
+func (m *MockRemoteConn) List(path string) ([]remote.FileInfo, error) {
+	return nil, nil
+}
+func (m *MockRemoteConn) MkDirAll(path string) error {
+	return nil
+}
+func (m *MockRemoteConn) Remove(path string) error {
+	return nil
+}
+func (m *MockRemoteConn) Stats(path string) (remote.FileInfo, error) {
+	return remote.FileInfo{}, nil
+}
+func (m *MockRemoteConn) WriteFile(data io.Reader, path string) error {
+	return nil
+}
+func (m *MockRemoteConn) GetCmd(cmd string, args ...string) remote.Cmder {
+	return nil
+}
+func (m *MockRemoteConn) Forward(ctx context.Context, localPort int, remotePort int) error {
+	return nil
+}
+func (m *MockRemoteConn) ForwardKillAll(ctx context.Context) error {
+	return nil
+}
+func createBuildInfoConnection(imageVersion string) remote.RemoteConn {
+	mockConn := MockRemoteConn{
+		ReadFileFunc: func(path string) (io.ReadCloser, error) {
+			return io.NopCloser(strings.NewReader(imageVersion)), nil
+		},
+	}
+	return &mockConn
+}
+
 func TestParseOSImageVersion(t *testing.T) {
 	tests := []struct {
 		name     string
@@ -30,10 +76,8 @@ func TestParseOSImageVersion(t *testing.T) {
 		found    bool
 	}{
 		{
-			name: "valid build id",
-			input: `BUILD_ID="20251006-395"
-			VARIANT_ID=xfce"
-			`,
+			name:     "valid build id",
+			input:    "BUILD_ID=\"20251006-395\"\nVARIANT_ID=xfce",
 			expected: "20251006-395",
 			found:    true,
 		},
@@ -48,12 +92,20 @@ func TestParseOSImageVersion(t *testing.T) {
 			found: false,
 		},
 	}
-
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			got, ok := parseOSImageVersion(strings.NewReader(tt.input))
-			require.Equal(t, tt.found, ok)
-			require.Equal(t, tt.expected, got)
+			if ok != tt.found || got != tt.expected {
+				t.Fatalf("got (%q, %v), expected (%q, %v)", got, ok, tt.expected, tt.found)
+			}
 		})
 	}
 }
+
+func TestGetOSImageVersion(t *testing.T) {
+	const R0_IMAGE_VERSION_ID = "20250807-136"
+	R0Version := createBuildInfoConnection(R0_IMAGE_VERSION_ID)
+	AnotherVersion := createBuildInfoConnection("BUILD_ID=20250101-001")
+	require.Equal(t, GetOSImageVersion(R0Version), R0_IMAGE_VERSION_ID)
+	require.Equal(t, GetOSImageVersion(AnotherVersion), "20250101-001")
+}