Feat/454 set example as default (#477)

Co-authored-by: mirkoCrobu <mirkocrobu@NB-0531.localdomain>

Author: mirkoCrobu

Taskfile.yml

@@ -201,11 +201,23 @@ tasks:
   setup:examples:local:
     desc: Download and locally install the official examples
     cmds:
-      - rm -rf ~/.arduino-app-cli/examples ~/.arduino-app-cli/tmp
-      - mkdir -p ~/.arduino-app-cli/tmp
-      - git clone https://github.com/bcmi-labs/app-bricks-example.git ~/.arduino-app-cli/tmp
-      - mv ~/.arduino-app-cli/tmp/examples ~/.arduino-app-cli/
-      - rm -rf ~/.arduino-app-cli/tmp
+      - |
+          set -e
+          DEST_PATH="$HOME/.config/arduino-app-cli/"
+          TMP_PATH="$(mktemp -d)"
+
+          echo "Cloning examples into temporary directory ${TMP_PATH}..."
+          git clone --depth 1 https://github.com/bcmi-labs/app-bricks-example.git "${TMP_PATH}"
+
+          echo "Installing examples to ${DEST_PATH}examples"
+          rm -rf "${DEST_PATH}examples"
+          mkdir -p "${DEST_PATH}"
+
+          mv "${TMP_PATH}/examples" "${DEST_PATH}"
+
+          rm -rf "${TMP_PATH}"
+          echo "Examples installed successfully."
+  silent: false
 
   wails:dev:
     desc: Run the Wails dev locally

internal/api/handlers/app_details.go

@@ -53,35 +53,44 @@ func HandleAppDetailsEdits(dockerClient *dockerClient.Client, bricksIndex *brick
 			render.EncodeResponse(w, http.StatusPreconditionFailed, models.ErrorResponse{Details: "invalid id"})
 			return
 		}
-		if id.IsExample() {
-			render.EncodeResponse(w, http.StatusBadRequest, models.ErrorResponse{Details: "cannot patch the example"})
-			return
-		}
-
 		app, err := app.Load(id.ToPath().String())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
 			return
 		}
 
+		var appEditRequest orchestrator.AppEditRequest
 		var editRequest EditRequest
+
 		if err := json.NewDecoder(r.Body).Decode(&editRequest); err != nil {
 			slog.Error("Unable to decode the request body", slog.String("error", err.Error()))
 			render.EncodeResponse(w, http.StatusBadRequest, models.ErrorResponse{Details: "invalid request"})
 			return
 		}
-		err = orchestrator.EditApp(orchestrator.AppEditRequest{
-			Default:     editRequest.Default,
-			Name:        editRequest.Name,
-			Icon:        editRequest.Icon,
-			Description: editRequest.Description,
-		}, &app)
+		if id.IsExample() {
+			if editRequest.Description != nil || editRequest.Icon != nil || editRequest.Name != nil {
+				render.EncodeResponse(w, http.StatusBadRequest, models.ErrorResponse{Details: "you can patch just the default field for example apps"})
+				return
+			}
+			appEditRequest = orchestrator.AppEditRequest{
+				Default: editRequest.Default,
+			}
+		} else {
+			appEditRequest = orchestrator.AppEditRequest{
+				Default:     editRequest.Default,
+				Name:        editRequest.Name,
+				Icon:        editRequest.Icon,
+				Description: editRequest.Description,
+			}
+		}
+		err = orchestrator.EditApp(appEditRequest, &app)
 		if err != nil {
 			slog.Error("Unable to edit the app", slog.String("error", err.Error()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to edit the app"})
 			return
 		}
+
 		res, err := orchestrator.AppDetails(r.Context(), dockerClient, app, bricksIndex)
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()))

internal/e2e/daemon/app_test.go

@@ -169,25 +169,6 @@ func TestEditApp(t *testing.T) {
 		require.NoError(t, err)
 		require.Equal(t, "invalid id", actualResponseBody.Details)
 	})
-
-	t.Run("PatchingExampleApp_Fail", func(t *testing.T) {
-		var actualResponseBody models.ErrorResponse
-		editResp, err := httpClient.EditApp(
-			t.Context(),
-			noExisitingExample,
-			client.EditRequest{Name: f.Ptr("any-name")},
-		)
-		require.NoError(t, err)
-		defer editResp.Body.Close()
-
-		require.Equal(t, http.StatusBadRequest, editResp.StatusCode)
-		body, err := io.ReadAll(editResp.Body)
-		require.NoError(t, err)
-		err = json.Unmarshal(body, &actualResponseBody)
-		require.NoError(t, err)
-		require.Equal(t, "cannot patch the example", actualResponseBody.Details)
-	})
-
 	t.Run("NonExistentAppId_Fail", func(t *testing.T) {
 		var actualResponseBody models.ErrorResponse
 		editResp, err := httpClient.EditApp(

internal/e2e/daemon/const.go

@@ -8,4 +8,5 @@ const (
 	noExistingApp                  = "dXNlcjp0ZXN0LWFwcAw"
 	malformedAppId                 = "this-is-definitely-not-base64"
 	noExisitingExample             = "ZXhhbXBsZXM6anVzdGJsaW5f"
+	existingExampleAppId           = "ZXhhbXBsZXM6YWlyLXF1YWxpdHktbW9uaXRvcmluZw"
 )