code review fix

Author: mirkoCrobu

internal/orchestrator/bricks/bricks.go

@@ -78,7 +78,7 @@ func (s *Service) AppBrickInstancesList(a *app.ArduinoApp) (AppBrickInstancesRes
 			return AppBrickInstancesResult{}, fmt.Errorf("brick not found with id %s", brickInstance.ID)
 		}
 
-		variablesMap, configVariables := getInstanceBrickConfigVAriableDetails(brick, brickInstance.Variables)
+		variablesMap, configVariables := getInstanceBrickConfigVariableDetails(brick, brickInstance.Variables)
 
 		res.BrickInstances[i] = BrickInstanceListItem{
 			ID:              brick.ID,
@@ -107,7 +107,7 @@ func (s *Service) AppBrickInstanceDetails(a *app.ArduinoApp, brickID string) (Br
 		return BrickInstance{}, fmt.Errorf("brick %s not added in the app", brickID)
 	}
 
-	variables, configVariables := getInstanceBrickConfigVAriableDetails(brick, a.Descriptor.Bricks[brickIndex].Variables)
+	variables, configVariables := getInstanceBrickConfigVariableDetails(brick, a.Descriptor.Bricks[brickIndex].Variables)
 
 	modelID := a.Descriptor.Bricks[brickIndex].Model
 	if modelID == "" {
@@ -134,7 +134,7 @@ func (s *Service) AppBrickInstanceDetails(a *app.ArduinoApp, brickID string) (Br
 	}, nil
 }
 
-func getInstanceBrickConfigVAriableDetails(
+func getInstanceBrickConfigVariableDetails(
 	brick *bricksindex.Brick, userVariables map[string]string,
 ) (map[string]string, []BrickConfigVariable) {
 	variablesMap := make(map[string]string, len(brick.Variables))

internal/orchestrator/bricks/bricks_test.go

@@ -317,7 +317,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			actualVariableMap, actualConfigVariables := getInstanceBrickConfigVAriableDetails(tt.brick, tt.userVariables)
+			actualVariableMap, actualConfigVariables := getInstanceBrickConfigVariableDetails(tt.brick, tt.userVariables)
 			require.Equal(t, tt.expectedVariableMap, actualVariableMap)
 			require.Equal(t, tt.expectedConfigVariables, actualConfigVariables)
 		})

internal/orchestrator/bricks/types.go

@@ -91,7 +91,7 @@ type BrickDetailsResult struct {
 	Category         string                   `json:"category"`
 	Status           string                   `json:"status"`
 	RequireModel     bool                     `json:"require_model"`
-	Variables        map[string]BrickVariable `json:"variables" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
+	Variables        map[string]BrickVariable `json:"variables, omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
 	Readme           string                   `json:"readme"`
 	ApiDocsPath      string                   `json:"api_docs_path"`
 	CodeExamples     []CodeExample            `json:"code_examples"`