Skip to content

Commit cf222e2

Browse files
committed
fix test
1 parent 23c61df commit cf222e2

File tree

4 files changed

+0
-47
lines changed

4 files changed

+0
-47
lines changed

cmd/gendoc/docs.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,6 @@ Contains a JSON object with the details of an error.
609609
Path: "/v1/apps",
610610
Request: handlers.CreateAppRequest{},
611611
Parameters: (*struct {
612-
SkipPython bool `query:"skip-python" description:"If true, the app will not be created with the python part."`
613612
SkipSketch bool `query:"skip-sketch" description:"If true, the app will not be created with the sketch part."`
614613
})(nil),
615614
CustomSuccessResponse: &CustomResponseDef{

internal/api/docs/openapi.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ paths:
4545
description: Creates a new app in the default app location.
4646
operationId: createApp
4747
parameters:
48-
- description: If true, the app will not be created with the python part.
49-
in: query
50-
name: skip-python
51-
schema:
52-
description: If true, the app will not be created with the python part.
53-
type: boolean
5448
- description: If true, the app will not be created with the sketch part.
5549
in: query
5650
name: skip-sketch

internal/e2e/client/client.gen.go

Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/e2e/daemon/app_test.go

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ func TestCreateApp(t *testing.T) {
9393
{
9494
name: "should return 400 bad request when icon is not a single emoji",
9595
parameters: client.CreateAppParams{
96-
SkipPython: f.Ptr(false),
9796
SkipSketch: f.Ptr(false),
9897
},
9998
body: client.CreateAppRequest{
@@ -107,7 +106,6 @@ func TestCreateApp(t *testing.T) {
107106
{
108107
name: "should create app successfully when icon is empty",
109108
parameters: client.CreateAppParams{
110-
SkipPython: f.Ptr(false),
111109
SkipSketch: f.Ptr(false),
112110
},
113111
body: client.CreateAppRequest{
@@ -121,7 +119,6 @@ func TestCreateApp(t *testing.T) {
121119
{
122120
name: "should return 201 Created on first successful creation",
123121
parameters: client.CreateAppParams{
124-
SkipPython: f.Ptr(false),
125122
SkipSketch: f.Ptr(false),
126123
},
127124
body: defaultRequestBody,
@@ -130,30 +127,15 @@ func TestCreateApp(t *testing.T) {
130127
{
131128
name: "should return 409 Conflict when creating a duplicate app",
132129
parameters: client.CreateAppParams{
133-
SkipPython: f.Ptr(false),
134130
SkipSketch: f.Ptr(false),
135131
},
136132
body: defaultRequestBody,
137133
expectedStatusCode: http.StatusConflict,
138134
expectedErrorDetails: f.Ptr("app already exists"),
139135
},
140-
{
141-
name: "should return 201 Created on successful creation with skip_python",
142-
parameters: client.CreateAppParams{
143-
SkipPython: f.Ptr(true),
144-
SkipSketch: f.Ptr(false),
145-
},
146-
body: client.CreateAppRequest{
147-
Icon: f.Ptr("🌎"),
148-
Name: "HelloWorld_2",
149-
Description: f.Ptr("My HelloWorld_2 description"),
150-
},
151-
expectedStatusCode: http.StatusCreated,
152-
},
153136
{
154137
name: "should return 201 Created on successful creation with skip_sketch",
155138
parameters: client.CreateAppParams{
156-
SkipPython: f.Ptr(false),
157139
SkipSketch: f.Ptr(true),
158140
},
159141
body: client.CreateAppRequest{
@@ -166,7 +148,6 @@ func TestCreateApp(t *testing.T) {
166148
{
167149
name: "should return 400 Bad Request when creating an app with both filters set to true",
168150
parameters: client.CreateAppParams{
169-
SkipPython: f.Ptr(true),
170151
SkipSketch: f.Ptr(true),
171152
},
172153
body: defaultRequestBody,
@@ -985,7 +966,6 @@ func TestAppList(t *testing.T) {
985966
expectedAppNumber := 5
986967
for i := 0; i < expectedAppNumber; i++ {
987968
r, err := httpClient.CreateApp(t.Context(), &client.CreateAppParams{
988-
SkipPython: f.Ptr(false),
989969
SkipSketch: f.Ptr(false),
990970
}, client.CreateAppRequest{
991971
Icon: f.Ptr("🌎"),
@@ -1003,7 +983,6 @@ func TestAppList(t *testing.T) {
1003983

1004984
t.Run("AppListDefault_success", func(t *testing.T) {
1005985
r, err := httpClient.CreateApp(t.Context(), &client.CreateAppParams{
1006-
SkipPython: f.Ptr(false),
1007986
SkipSketch: f.Ptr(false),
1008987
}, client.CreateAppRequest{
1009988
Icon: f.Ptr("🌎"),

0 commit comments

Comments
 (0)