Appease linter

Author: MatteoPologruto

internal/updater/http_client.go

@@ -137,8 +137,8 @@ func (c *Client) FetchZip(ctx context.Context, zipURL string) (io.ReadCloser, in
 // DownloadFile downloads a file from a URL into the specified path. An optional config and options may be passed (or nil to use the defaults).
 // A DownloadProgressCB callback function must be passed to monitor download progress.
 // If a not empty queryParameter is passed, it is appended to the URL for analysis purposes.
-func DownloadFile(ctx context.Context, path *paths.Path, URL string, label string, downloadCB flasher.DownloadProgressCB, config downloader.Config, options ...downloader.DownloadOptions) (returnedError error) {
-	downloadCB.Start(URL, label)
+func DownloadFile(ctx context.Context, path *paths.Path, url string, label string, downloadCB flasher.DownloadProgressCB, config downloader.Config, options ...downloader.DownloadOptions) (returnedError error) {
+	downloadCB.Start(url, label)
 	defer func() {
 		if returnedError == nil {
 			downloadCB.End(true, "")
@@ -147,7 +147,7 @@ func DownloadFile(ctx context.Context, path *paths.Path, URL string, label strin
 		}
 	}()
 
-	d, err := downloader.DownloadWithConfigAndContext(ctx, path.String(), URL, config, options...)
+	d, err := downloader.DownloadWithConfigAndContext(ctx, path.String(), url, config, options...)
 	if err != nil {
 		return err
 	}

service/service_download.go

@@ -29,7 +29,7 @@ func (s *flasherServerImpl) Download(req *flasher.DownloadRequest, stream flashe
 	syncSend := NewSynchronizedSend(stream.Send)
 	ctx := stream.Context()
 	downloadCB := func(p *flasher.DownloadProgress) {
-		syncSend.Send(&flasher.DownloadResponse{
+		_ = syncSend.Send(&flasher.DownloadResponse{
 			Message: &flasher.DownloadResponse_Progress{Progress: p},
 		})
 	}

service/service_flash.go

@@ -38,7 +38,7 @@ func (s *flasherServerImpl) Flash(req *flasher.FlashRequest, stream flasher.Flas
 	}
 	ctx := stream.Context()
 	downloadCB := func(msg *flasher.DownloadProgress) {
-		responseCallback(&flasher.FlashResponse{
+		_ = responseCallback(&flasher.FlashResponse{
 			Message: &flasher.FlashResponse_DownloadProgress{
 				DownloadProgress: &flasher.DownloadProgress{
 					Message: msg.GetMessage(),
@@ -47,7 +47,7 @@ func (s *flasherServerImpl) Flash(req *flasher.FlashRequest, stream flasher.Flas
 		})
 	}
 	extractCB := func(msg *flasher.TaskProgress) {
-		responseCallback(&flasher.FlashResponse{
+		_ = responseCallback(&flasher.FlashResponse{
 			Message: &flasher.FlashResponse_ExtractionProgress{
 				ExtractionProgress: &flasher.TaskProgress{
 					Name:      msg.GetName(),
@@ -58,7 +58,7 @@ func (s *flasherServerImpl) Flash(req *flasher.FlashRequest, stream flasher.Flas
 		})
 	}
 	flashCB := func(msg *flasher.TaskProgress) {
-		responseCallback(&flasher.FlashResponse{
+		_ = responseCallback(&flasher.FlashResponse{
 			Message: &flasher.FlashResponse_FlashProgress{
 				FlashProgress: &flasher.TaskProgress{
 					Name:      msg.GetName(),
@@ -101,7 +101,7 @@ func (s *flasherServerImpl) Flash(req *flasher.FlashRequest, stream flasher.Flas
 	}
 
 	tmpZip := paths.New(req.GetTempPath(), "arduino-unoq-debian-image-"+rel.Version+".tar.zst")
-	defer tmpZip.RemoveAll()
+	defer func() { _ = tmpZip.RemoveAll() }()
 
 	if err := updater.DownloadFile(ctx, tmpZip, rel.Url, rel.Version, downloadCB, downloader.Config{}); err != nil {
 		return err
@@ -123,7 +123,7 @@ func (s *flasherServerImpl) Flash(req *flasher.FlashRequest, stream flasher.Flas
 	extractCB(&flasher.TaskProgress{Name: "extract", Completed: true})
 
 	imagePath := tmpZip.Parent().Join("arduino-unoq-debian-image-" + rel.Version)
-	defer imagePath.RemoveAll()
+	defer func() { _ = imagePath.RemoveAll() }()
 
 	flashCB(&flasher.TaskProgress{Name: "flash", Message: "Starting"})
 	if err := updater.FlashBoard(ctx, imagePath.String(), rel.Version, req.GetPreserveUser()); err != nil {