From dc8ebc9a0c4501ad0a92ffd71920af6c8c30f60a Mon Sep 17 00:00:00 2001 From: Dimitris Apostolou Date: Wed, 12 Feb 2025 20:46:05 +0200 Subject: [PATCH] fix: fix clippy warnings --- core/src/air/builder.rs | 16 ++++--------- core/src/air/machine.rs | 4 ++-- core/src/air/sub_builder.rs | 7 ++++-- core/src/memory/columns.rs | 2 +- core/src/operations/field/field_op.rs | 1 - core/src/runtime/hooks.rs | 4 ++-- core/src/runtime/io.rs | 4 ++-- core/src/runtime/utils.rs | 2 +- core/src/stark/debug.rs | 17 ++++++-------- core/src/stark/folder.rs | 30 ++++++++++++------------- core/src/stark/permutation.rs | 1 - core/src/utils/programs.rs | 2 -- prover/src/utils.rs | 2 +- recursion/compiler/src/asm/compiler.rs | 8 ++----- recursion/compiler/src/ir/builder.rs | 4 ++-- recursion/core/src/air/multi_builder.rs | 12 +++++----- recursion/core/src/memory/columns.rs | 8 +++---- recursion/program/src/fri/mod.rs | 2 -- recursion/program/src/hints.rs | 8 +++---- zkvm/entrypoint/src/syscalls/mod.rs | 2 +- 20 files changed, 58 insertions(+), 78 deletions(-) diff --git a/core/src/air/builder.rs b/core/src/air/builder.rs index 3dd4d59ae..2eb01b2f3 100644 --- a/core/src/air/builder.rs +++ b/core/src/air/builder.rs @@ -88,7 +88,6 @@ pub trait BaseAirBuilder: AirBuilder + MessageBuilder /// A trait which contains methods for byte interactions in an AIR. pub trait ByteAirBuilder: BaseAirBuilder { /// Sends a byte operation to be processed. - fn send_byte( &mut self, opcode: impl Into, @@ -112,7 +111,6 @@ pub trait ByteAirBuilder: BaseAirBuilder { } /// Sends a byte operation with two outputs to be processed. - fn send_byte_pair( &mut self, opcode: impl Into, @@ -140,7 +138,6 @@ pub trait ByteAirBuilder: BaseAirBuilder { } /// Receives a byte operation to be processed. - fn receive_byte( &mut self, opcode: impl Into, @@ -164,7 +161,6 @@ pub trait ByteAirBuilder: BaseAirBuilder { } /// Receives a byte operation with two outputs to be processed. - fn receive_byte_pair( &mut self, opcode: impl Into, @@ -303,7 +299,6 @@ pub trait WordAirBuilder: ByteAirBuilder { /// A trait which contains methods related to ALU interactions in an AIR. pub trait AluAirBuilder: BaseAirBuilder { /// Sends an ALU operation to be processed. - fn send_alu( &mut self, opcode: impl Into, @@ -332,7 +327,6 @@ pub trait AluAirBuilder: BaseAirBuilder { } /// Receives an ALU operation to be processed. - fn receive_alu( &mut self, opcode: impl Into, @@ -361,7 +355,6 @@ pub trait AluAirBuilder: BaseAirBuilder { } /// Sends an syscall operation to be processed (with "ECALL" opcode). - fn send_syscall( &mut self, shard: impl Into + Clone, @@ -389,7 +382,6 @@ pub trait AluAirBuilder: BaseAirBuilder { } /// Receives a syscall operation to be processed. - fn receive_syscall( &mut self, shard: impl Into + Clone, @@ -712,7 +704,7 @@ pub trait SphinxAirBuilder: { } -impl<'a, AB: AirBuilder + MessageBuilder, M> MessageBuilder for FilteredAirBuilder<'a, AB> { +impl, M> MessageBuilder for FilteredAirBuilder<'_, AB> { fn send(&mut self, message: M) { self.inner.send(message); } @@ -732,10 +724,10 @@ impl ExtensionAirBuilder for AB {} impl MachineAirBuilder for AB {} impl SphinxAirBuilder for AB {} -impl<'a, SC: StarkGenericConfig> EmptyMessageBuilder for ProverConstraintFolder<'a, SC> {} -impl<'a, SC: StarkGenericConfig> EmptyMessageBuilder for VerifierConstraintFolder<'a, SC> {} +impl EmptyMessageBuilder for ProverConstraintFolder<'_, SC> {} +impl EmptyMessageBuilder for VerifierConstraintFolder<'_, SC> {} impl EmptyMessageBuilder for SymbolicAirBuilder {} #[cfg(debug_assertions)] #[cfg(not(doctest))] -impl<'a, F: Field> EmptyMessageBuilder for p3_uni_stark::DebugConstraintBuilder<'a, F> {} +impl EmptyMessageBuilder for p3_uni_stark::DebugConstraintBuilder<'_, F> {} diff --git a/core/src/air/machine.rs b/core/src/air/machine.rs index da71e27db..a132c3a39 100644 --- a/core/src/air/machine.rs +++ b/core/src/air/machine.rs @@ -57,7 +57,7 @@ where } } -impl<'a, T, R, U, F> EventLens for Proj<'a, T, R, F> +impl EventLens for Proj<'_, T, R, F> where T: for<'b> WithEvents<'b>, R: EventLens, @@ -71,7 +71,7 @@ where } } -impl<'a, T, R, F> Indexed for Proj<'a, T, R, F> +impl Indexed for Proj<'_, T, R, F> where T: for<'b> WithEvents<'b>, R: EventLens + Indexed, diff --git a/core/src/air/sub_builder.rs b/core/src/air/sub_builder.rs index cd1f6be8a..883a7cb73 100644 --- a/core/src/air/sub_builder.rs +++ b/core/src/air/sub_builder.rs @@ -23,7 +23,10 @@ impl, T: Send + Sync> SubMatrixRowSlices { /// Implement `Matrix` for `SubMatrixRowSlices`. impl, T: Send + Sync> Matrix for SubMatrixRowSlices { - type Row<'a> = Skip>> where Self: 'a; + type Row<'a> + = Skip>> + where + Self: 'a; #[inline] fn row(&self, r: usize) -> Self::Row<'_> { @@ -69,7 +72,7 @@ impl<'a, AB: AirBuilder, SubAir: BaseAir, T> SubAirBuilder<'a, AB, SubAir, T> } /// Implement `AirBuilder` for `SubAirBuilder`. -impl<'a, AB: AirBuilder, SubAir: BaseAir, F> AirBuilder for SubAirBuilder<'a, AB, SubAir, F> { +impl, F> AirBuilder for SubAirBuilder<'_, AB, SubAir, F> { type F = AB::F; type Expr = AB::Expr; type Var = AB::Var; diff --git a/core/src/memory/columns.rs b/core/src/memory/columns.rs index 7602d47b8..9955d7172 100644 --- a/core/src/memory/columns.rs +++ b/core/src/memory/columns.rs @@ -41,7 +41,7 @@ pub struct MemoryAccessCols { /// The following columns are decomposed limbs for the difference between the current access's timestamp /// and the previous access's timestamp. Note the actual value of the timestamp is either the /// accesses' shard or clk depending on the value of compare_clk. - + /// /// This column is the least significant 16 bit limb of current access timestamp - prev access timestamp. pub diff_16bit_limb: T, diff --git a/core/src/operations/field/field_op.rs b/core/src/operations/field/field_op.rs index 56e6c892b..fd1847947 100644 --- a/core/src/operations/field/field_op.rs +++ b/core/src/operations/field/field_op.rs @@ -119,7 +119,6 @@ impl FieldOpCols { /// Populate these columns with a specified modulus. This is useful in the `mulmod` precompile /// as an example. - pub fn populate_with_modulus( &mut self, record: &mut impl ByteRecord, diff --git a/core/src/runtime/hooks.rs b/core/src/runtime/hooks.rs index b1096abc8..aafa52279 100644 --- a/core/src/runtime/hooks.rs +++ b/core/src/runtime/hooks.rs @@ -67,7 +67,7 @@ impl<'a> HookRegistry<'a> { } } -impl<'a> Default for HookRegistry<'a> { +impl Default for HookRegistry<'_> { fn default() -> Self { // When `LazyCell` gets stabilized (1.81.0), we can use it to avoid unnecessary allocations. let table = HashMap::from([ @@ -80,7 +80,7 @@ impl<'a> Default for HookRegistry<'a> { } } -impl<'a> Debug for HookRegistry<'a> { +impl Debug for HookRegistry<'_> { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { let mut keys = self.table.keys().collect::>(); keys.sort_unstable(); diff --git a/core/src/runtime/io.rs b/core/src/runtime/io.rs index a5c132d8c..cfde14297 100644 --- a/core/src/runtime/io.rs +++ b/core/src/runtime/io.rs @@ -8,14 +8,14 @@ use serde::Serialize; use super::Runtime; -impl<'a> Read for Runtime<'a> { +impl Read for Runtime<'_> { fn read(&mut self, buf: &mut [u8]) -> std::io::Result { self.read_public_values_slice(buf); Ok(buf.len()) } } -impl<'a> Runtime<'a> { +impl Runtime<'_> { pub fn write_stdin(&mut self, input: &T) { let mut buf = Vec::new(); bincode::serialize_into(&mut buf, input).expect("serialization failed"); diff --git a/core/src/runtime/utils.rs b/core/src/runtime/utils.rs index 41e132bcc..b1110e318 100644 --- a/core/src/runtime/utils.rs +++ b/core/src/runtime/utils.rs @@ -30,7 +30,7 @@ macro_rules! assert_valid_memory_access { }; } -impl<'a> Runtime<'a> { +impl Runtime<'_> { #[inline] pub fn log(&mut self, instruction: &Instruction) { // Write the current program counter to the trace buffer for the cycle tracer. diff --git a/core/src/stark/debug.rs b/core/src/stark/debug.rs index e7aa51797..d774abaa2 100644 --- a/core/src/stark/debug.rs +++ b/core/src/stark/debug.rs @@ -139,7 +139,7 @@ pub struct DebugConstraintBuilder<'a, F: Field, EF: ExtensionField> { pub(crate) public_values: &'a [F], } -impl<'a, F, EF> ExtensionBuilder for DebugConstraintBuilder<'a, F, EF> +impl ExtensionBuilder for DebugConstraintBuilder<'_, F, EF> where F: Field, EF: ExtensionField, @@ -174,7 +174,7 @@ where } } -impl<'a, F, EF> PairBuilder for DebugConstraintBuilder<'a, F, EF> +impl PairBuilder for DebugConstraintBuilder<'_, F, EF> where F: Field, EF: ExtensionField, @@ -184,7 +184,7 @@ where } } -impl<'a, F, EF> DebugConstraintBuilder<'a, F, EF> +impl DebugConstraintBuilder<'_, F, EF> where F: Field, EF: ExtensionField, @@ -252,7 +252,7 @@ where } } -impl<'a, F, EF> MultiTableAirBuilder for DebugConstraintBuilder<'a, F, EF> +impl MultiTableAirBuilder for DebugConstraintBuilder<'_, F, EF> where F: Field, EF: ExtensionField, @@ -264,13 +264,10 @@ where } } -impl<'a, F: Field, EF: ExtensionField> EmptyMessageBuilder - for DebugConstraintBuilder<'a, F, EF> -{ -} +impl> EmptyMessageBuilder for DebugConstraintBuilder<'_, F, EF> {} -impl<'a, F: Field, EF: ExtensionField> AirBuilderWithPublicValues - for DebugConstraintBuilder<'a, F, EF> +impl> AirBuilderWithPublicValues + for DebugConstraintBuilder<'_, F, EF> { type PublicVar = F; diff --git a/core/src/stark/folder.rs b/core/src/stark/folder.rs index 50bec94e1..ab86a2ca8 100644 --- a/core/src/stark/folder.rs +++ b/core/src/stark/folder.rs @@ -66,7 +66,7 @@ impl<'a, SC: StarkGenericConfig> AirBuilder for ProverConstraintFolder<'a, SC> { } } -impl<'a, SC: StarkGenericConfig> ExtensionBuilder for ProverConstraintFolder<'a, SC> { +impl ExtensionBuilder for ProverConstraintFolder<'_, SC> { type EF = SC::Challenge; type ExprEF = PackedChallenge; @@ -100,7 +100,7 @@ impl<'a, SC: StarkGenericConfig> PermutationAirBuilder for ProverConstraintFolde } } -impl<'a, SC: StarkGenericConfig> MultiTableAirBuilder for ProverConstraintFolder<'a, SC> { +impl MultiTableAirBuilder for ProverConstraintFolder<'_, SC> { type Sum = PackedChallenge; fn cumulative_sum(&self) -> Self::Sum { @@ -108,15 +108,15 @@ impl<'a, SC: StarkGenericConfig> MultiTableAirBuilder for ProverConstraintFolder } } -impl<'a, SC: StarkGenericConfig> PairBuilder for ProverConstraintFolder<'a, SC> { +impl PairBuilder for ProverConstraintFolder<'_, SC> { fn preprocessed(&self) -> Self::M { self.preprocessed } } -impl<'a, SC: StarkGenericConfig> EmptyMessageBuilder for ProverConstraintFolder<'a, SC> {} +impl EmptyMessageBuilder for ProverConstraintFolder<'_, SC> {} -impl<'a, SC: StarkGenericConfig> AirBuilderWithPublicValues for ProverConstraintFolder<'a, SC> { +impl AirBuilderWithPublicValues for ProverConstraintFolder<'_, SC> { type PublicVar = Self::F; fn public_values(&self) -> &[Self::PublicVar] { @@ -210,8 +210,8 @@ where } } -impl<'a, F, EF, PubVar, Var, Expr> ExtensionBuilder - for GenericVerifierConstraintFolder<'a, F, EF, PubVar, Var, Expr> +impl ExtensionBuilder + for GenericVerifierConstraintFolder<'_, F, EF, PubVar, Var, Expr> where F: Field, EF: ExtensionField, @@ -292,8 +292,8 @@ where } } -impl<'a, F, EF, PubVar, Var, Expr> MultiTableAirBuilder - for GenericVerifierConstraintFolder<'a, F, EF, PubVar, Var, Expr> +impl MultiTableAirBuilder + for GenericVerifierConstraintFolder<'_, F, EF, PubVar, Var, Expr> where F: Field, EF: ExtensionField, @@ -328,8 +328,8 @@ where } } -impl<'a, F, EF, PubVar, Var, Expr> PairBuilder - for GenericVerifierConstraintFolder<'a, F, EF, PubVar, Var, Expr> +impl PairBuilder + for GenericVerifierConstraintFolder<'_, F, EF, PubVar, Var, Expr> where F: Field, EF: ExtensionField, @@ -362,8 +362,8 @@ where } } -impl<'a, F, EF, PubVar, Var, Expr> EmptyMessageBuilder - for GenericVerifierConstraintFolder<'a, F, EF, PubVar, Var, Expr> +impl EmptyMessageBuilder + for GenericVerifierConstraintFolder<'_, F, EF, PubVar, Var, Expr> where F: Field, EF: ExtensionField, @@ -393,8 +393,8 @@ where { } -impl<'a, F, EF, PubVar, Var, Expr> AirBuilderWithPublicValues - for GenericVerifierConstraintFolder<'a, F, EF, PubVar, Var, Expr> +impl AirBuilderWithPublicValues + for GenericVerifierConstraintFolder<'_, F, EF, PubVar, Var, Expr> where F: Field, EF: ExtensionField, diff --git a/core/src/stark/permutation.rs b/core/src/stark/permutation.rs index 85d0a77e3..887db00f1 100644 --- a/core/src/stark/permutation.rs +++ b/core/src/stark/permutation.rs @@ -10,7 +10,6 @@ use rayon_scan::ScanParallelIterator; use crate::{air::MultiTableAirBuilder, lookup::Interaction}; #[inline] - pub fn populate_permutation_row>( row: &mut [EF], preprocessed_row: &[F], diff --git a/core/src/utils/programs.rs b/core/src/utils/programs.rs index 9984c2960..c3b9bc7a9 100644 --- a/core/src/utils/programs.rs +++ b/core/src/utils/programs.rs @@ -1,7 +1,6 @@ #![allow(unused)] pub mod tests { /// Demos. - pub const CHESS_ELF: &[u8] = include_bytes!("../../../examples/chess/program/elf/riscv32im-succinct-zkvm-elf"); @@ -27,7 +26,6 @@ pub mod tests { include_bytes!("../../../examples/tendermint/program/elf/riscv32im-succinct-zkvm-elf"); /// Tests. - pub const FIBONACCI_ELF: &[u8] = include_bytes!("../../../tests/fibonacci/elf/riscv32im-succinct-zkvm-elf"); diff --git a/prover/src/utils.rs b/prover/src/utils.rs index 6053386cf..ecb763627 100644 --- a/prover/src/utils.rs +++ b/prover/src/utils.rs @@ -43,7 +43,7 @@ pub fn load_elf(path: &str) -> Result, std::io::Error> { } pub fn words_to_bytes(words: &[Word]) -> Vec { - return words.iter().flat_map(|word| word.0).collect(); + words.iter().flat_map(|word| word.0).collect() } /// Convert 8 BabyBear words into a Bn254Fr field element by shifting by 31 bits each time. The last diff --git a/recursion/compiler/src/asm/compiler.rs b/recursion/compiler/src/asm/compiler.rs index a72ed5c47..844006920 100644 --- a/recursion/compiler/src/asm/compiler.rs +++ b/recursion/compiler/src/asm/compiler.rs @@ -661,9 +661,7 @@ pub struct IfCompiler<'a, F, EF> { is_eq: bool, } -impl<'a, F: PrimeField32 + TwoAdicField, EF: ExtensionField + TwoAdicField> - IfCompiler<'a, F, EF> -{ +impl + TwoAdicField> IfCompiler<'_, F, EF> { pub fn then(self, f: Func) where Func: FnOnce(&mut AsmCompiler), @@ -758,9 +756,7 @@ pub struct ForCompiler<'a, F, EF> { loop_var: Var, } -impl<'a, F: PrimeField32 + TwoAdicField, EF: ExtensionField + TwoAdicField> - ForCompiler<'a, F, EF> -{ +impl + TwoAdicField> ForCompiler<'_, F, EF> { pub(super) fn for_each(mut self, f: impl FnOnce(Var, &mut AsmCompiler)) { // The function block structure: // - Setting the loop range diff --git a/recursion/compiler/src/ir/builder.rs b/recursion/compiler/src/ir/builder.rs index 859167433..a467b89aa 100644 --- a/recursion/compiler/src/ir/builder.rs +++ b/recursion/compiler/src/ir/builder.rs @@ -542,7 +542,7 @@ enum IfCondition { NeI(Var, N), } -impl<'a, C: Config> IfBuilder<'a, C> { +impl IfBuilder<'_, C> { pub fn then(mut self, mut f: impl FnMut(&mut Builder)) { // Get the condition reduced from the expressions for lhs and rhs. let condition = self.condition(); @@ -745,7 +745,7 @@ pub struct RangeBuilder<'a, C: Config> { builder: &'a mut Builder, } -impl<'a, C: Config> RangeBuilder<'a, C> { +impl RangeBuilder<'_, C> { pub const fn step_by(mut self, step_size: usize) -> Self { self.step_size = step_size; self diff --git a/recursion/core/src/air/multi_builder.rs b/recursion/core/src/air/multi_builder.rs index 1562d3c4a..fa9009d8a 100644 --- a/recursion/core/src/air/multi_builder.rs +++ b/recursion/core/src/air/multi_builder.rs @@ -21,7 +21,7 @@ impl<'a, AB: AirBuilder> MultiBuilder<'a, AB> { } } -impl<'a, AB: AirBuilder> AirBuilder for MultiBuilder<'a, AB> { +impl AirBuilder for MultiBuilder<'_, AB> { type F = AB::F; type Expr = AB::Expr; type Var = AB::Var; @@ -48,7 +48,7 @@ impl<'a, AB: AirBuilder> AirBuilder for MultiBuilder<'a, AB> { } } -impl<'a, AB: ExtensionBuilder> ExtensionBuilder for MultiBuilder<'a, AB> { +impl ExtensionBuilder for MultiBuilder<'_, AB> { type EF = AB::EF; type VarEF = AB::VarEF; type ExprEF = AB::ExprEF; @@ -61,7 +61,7 @@ impl<'a, AB: ExtensionBuilder> ExtensionBuilder for MultiBuilder<'a, AB> { } } -impl<'a, AB: PermutationAirBuilder> PermutationAirBuilder for MultiBuilder<'a, AB> { +impl PermutationAirBuilder for MultiBuilder<'_, AB> { type MP = AB::MP; type RandomVar = AB::RandomVar; @@ -75,7 +75,7 @@ impl<'a, AB: PermutationAirBuilder> PermutationAirBuilder for MultiBuilder<'a, A } } -impl<'a, AB: AirBuilder + MessageBuilder, M> MessageBuilder for MultiBuilder<'a, AB> { +impl, M> MessageBuilder for MultiBuilder<'_, AB> { fn send(&mut self, message: M) { self.inner.send(message); } @@ -85,8 +85,8 @@ impl<'a, AB: AirBuilder + MessageBuilder, M> MessageBuilder for MultiBuild } } -impl<'a, AB: AirBuilder + AirBuilderWithPublicValues> AirBuilderWithPublicValues - for MultiBuilder<'a, AB> +impl AirBuilderWithPublicValues + for MultiBuilder<'_, AB> { type PublicVar = AB::PublicVar; diff --git a/recursion/core/src/memory/columns.rs b/recursion/core/src/memory/columns.rs index fc2ef924f..972d19628 100644 --- a/recursion/core/src/memory/columns.rs +++ b/recursion/core/src/memory/columns.rs @@ -15,7 +15,7 @@ pub struct MemoryInitCols { /// This column is the least significant 16 bit limb of next_address - current_address. pub diff_16bit_limb: T, - /// This column is the most signficant 8 bit limb of next_address - current_addres. + /// This column is the most significant 8 bit limb of next_address - current_address. pub diff_12bit_limb: T, /// Same for the address column. @@ -51,7 +51,7 @@ impl MemoryInitCols { /// NOTE: These are very similar to core/src/memory/columns.rs /// The reason we cannot use those structs directly is that they use "shard". /// In our recursive VM, we don't have shards, we only have `clk` (i.e. timestamp). - +/// /// Memory read access. #[derive(AlignedBorrow, Default, Debug, Clone, Copy)] #[repr(C)] @@ -94,11 +94,11 @@ pub struct MemoryAccessCols { /// The following columns are decomposed limbs for the difference between the current access's timestamp /// and the previous access's timestamp. Note the actual value of the timestamp is either the /// accesses' shard or clk depending on the value of compare_clk. - + /// /// This column is the least significant 16 bit limb of current access timestamp - prev access timestamp. pub diff_16bit_limb: T, - /// This column is the most signficant 12 bit limb of current access timestamp - prev access timestamp. + /// This column is the most significant 12 bit limb of current access timestamp - prev access timestamp. pub diff_12bit_limb: T, } diff --git a/recursion/program/src/fri/mod.rs b/recursion/program/src/fri/mod.rs index 4abaf5e68..1fc97eb12 100644 --- a/recursion/program/src/fri/mod.rs +++ b/recursion/program/src/fri/mod.rs @@ -82,7 +82,6 @@ pub fn verify_shape_and_sample_challenges( /// Verifies a set of FRI challenges. /// /// Reference: https://github.com/Plonky3/Plonky3/blob/4809fa7bedd9ba8f6f5d3267b1592618e3776c57/fri/src/verifier.rs#L67 - pub fn verify_challenges( builder: &mut Builder, config: &FriConfigVariable, @@ -221,7 +220,6 @@ where /// Assumes the dimensions have already been sorted by tallest first. /// /// Reference: https://github.com/Plonky3/Plonky3/blob/4809fa7bedd9ba8f6f5d3267b1592618e3776c57/merkle-tree/src/mmcs.rs#L92 - #[allow(unused_variables)] pub fn verify_batch( builder: &mut Builder, diff --git a/recursion/program/src/hints.rs b/recursion/program/src/hints.rs index 4dad66cdf..bf85db0a6 100644 --- a/recursion/program/src/hints.rs +++ b/recursion/program/src/hints.rs @@ -149,7 +149,7 @@ impl Hintable for TwoAdicMultiplicativeCoset { trait VecAutoHintable: Hintable {} -impl<'a, A: MachineAir> VecAutoHintable for ShardProofHint<'a, BabyBearPoseidon2, A> {} +impl> VecAutoHintable for ShardProofHint<'_, BabyBearPoseidon2, A> {} impl VecAutoHintable for TwoAdicMultiplicativeCoset {} impl VecAutoHintable for Vec {} impl VecAutoHintable for QuotientDataValues {} @@ -420,14 +420,13 @@ impl Hintable for DuplexChallenger { } impl< - 'a, SC: StarkGenericConfig< Pcs = ::Pcs, Challenge = ::Challenge, Challenger = ::Challenger, >, A: MachineAir, - > Hintable for VerifyingKeyHint<'a, SC, A> + > Hintable for VerifyingKeyHint<'_, SC, A> { type HintVariable = VerifyingKeyVariable; @@ -459,14 +458,13 @@ impl< // Implement Hintable for ShardProof where SC is equivalent to BabyBearPoseidon2 impl< - 'a, SC: StarkGenericConfig< Pcs = ::Pcs, Challenge = ::Challenge, Challenger = ::Challenger, >, A: MachineAir, - > Hintable for ShardProofHint<'a, SC, A> + > Hintable for ShardProofHint<'_, SC, A> where ShardCommitment>: Hintable, { diff --git a/zkvm/entrypoint/src/syscalls/mod.rs b/zkvm/entrypoint/src/syscalls/mod.rs index 92381ddfd..68335076d 100644 --- a/zkvm/entrypoint/src/syscalls/mod.rs +++ b/zkvm/entrypoint/src/syscalls/mod.rs @@ -36,7 +36,7 @@ pub use verify::*; /// These codes MUST match the codes in `core/src/runtime/syscall.rs`. There is a derived test /// that checks that the enum is consistent with the syscalls. - +/// /// Halts the program. pub const HALT: u32 = 0x00_00_00_00;