-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Description
This isn’t happening in every font, or maybe not even most fonts. It could be an issue with the fonts themselves. However, I want to track it so I can maybe figure it out. The main error from the extension console is:
popup.js:2 Failure to load named instances: TypeError: Cannot read properties of undefined (reading 'en')
at get namedVariations (831.bundle.js:2:441259)
at r.get (831.bundle.js:2:209402)
at o.<anonymous> (popup.js:2:34628)
at popup.js:2:31681
at Object.next (popup.js:2:31786)
at i (popup.js:2:30433)
It seems it may boil down to this:
foliojs/fontkit#272
Looking at the fonts where this does and doesn’t work, it does some that:
- If the default instance in
fvarpoints to a nameID above 255, the instance menu loads. Examples: Open Sans, Shantell Sans, AT Name Sans - If the default instance in
fvarpoints to a nameID that is not represented above 255, such as a "Regular"fvardefault that points to nameID 2 or 17, the error occurs. Examples: AT Kyrios, AT Lang, AT Name Mono.
Looks like it could potentially be fixed with foliojs/fontkit#324, but that PR is still open.
Metadata
Metadata
Assignees
Labels
No labels