Skip to content

Conversation

@martincostello
Copy link
Member

  • Enable scanning GitHub Actions workflows with CodeQL.
  • Make permissions job-level rather than workflow-level.
  • Do not persist Git credentials.
  • Simplify some conditions.
  • Use environment variables to make code to push NuGet packages consistent.
  • Update branch name.
  • Scan the GitHub workflows using zizmor.

Enable scanning GitHub Actions workflows with CodeQL.
- Make permissions job-level rather than workflow-level.
- Do not persist Git credentials.
- Simplify some conditions.
- Use environment variables to make code to push NuGet packages consistent.
- Update branch name.
Scan the GitHub workflows using zizmor.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 15, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@martincostello martincostello marked this pull request as ready for review August 15, 2025 14:51
Copilot AI review requested due to automatic review settings August 15, 2025 14:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the security and maintainability of GitHub Actions workflows by adding CodeQL scanning for workflow files, improving security practices, and standardizing configurations.

  • Adds CodeQL scanning support for GitHub Actions workflows in addition to existing C# code scanning
  • Introduces zizmor tool for dedicated GitHub workflow security scanning
  • Moves permissions from workflow-level to job-level for better security isolation
  • Standardizes environment variable usage for NuGet package publishing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/update-dotnet-sdks.yml Updates branch option and moves permissions to job-level
.github/workflows/code-scan.yml Adds GitHub Actions scanning to CodeQL matrix and introduces zizmor workflow scanner
.github/workflows/build.yml Enhances security with credential settings, simplifies conditions, and standardizes NuGet publishing variables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement github_actions Pull requests that update GitHub Actions code

Development

Successfully merging this pull request may close these issues.

2 participants